Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tfsdk: Remove diagnostics helper methods on response types #198

Merged
merged 3 commits into from
Oct 5, 2021
Merged

tfsdk: Remove diagnostics helper methods on response types #198

merged 3 commits into from
Oct 5, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 4, 2021 •
edited
Loading

Closes #196

The Diagnostics field on these types provides the same methods.

@bflad
tfsdk: Remove diagnostics helper methods on response types
7a1af6c 
Reference: #196

The `Diagnostics` field on these types provides the same methods.
@bflad bflad added breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. tech-debt Issues tracking technical debt that we're carrying. labels Oct 4, 2021
@bflad bflad requested a review from a team October 4, 2021 19:21
kmoe
kmoe approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The time has come at last. RIP

paddycarver
paddycarver approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My favorite kind of PR.

@kmoe kmoe added this to the v0.5.0 milestone Oct 5, 2021
@bflad bflad merged commit ba1b062 into main Oct 5, 2021
@bflad bflad deleted the bflad-td-response-Diagnostics-methods branch October 5, 2021 21:06
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kmoe kmoe kmoe approved these changes

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. tech-debt Issues tracking technical debt that we're carrying.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

tfsdk: Standardize Response Type Diagnostics Handling
3 participants
@bflad @paddycarver @kmoe