Add state preserving plan modifiers #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddycarver
force-pushed
the
prior-state-helper-plan-modifiers
branch
from
ce9e0fb to
e33b1ba
Compare
|
I updated this to be more robust around how it's handling null states, to only ever overwrite unknown values, and to preserve unknown config values (interpolated values). I also added unit test cases verifying the above. I think it's ready for review. |
paddycarver
added a commit
to hashicorp/terraform-provider-corner
that referenced
this pull request
Oct 26, 2021
Update the framework to use hashicorp/terraform-plugin-framework#204. Add "language" as a property of user, simulating an optional+computed value with a default. Add "date_joined" as a property of user, simulating a write-once computed-only value. Update framework user tests to check actual values (which we can do, because they're known) instead of using unnecessary regular expressions. Check all the attributes in state for our framework user tests. Add framework user test that language can optionally be set. Add framework user test that language can be interpolated successfully even with the PreserveState modifier on it.
paddycarver
force-pushed
the
prior-state-helper-plan-modifiers
branch
from
b0bf04e to
1d1b129
Compare
bflad
approved these changes
Nov 1, 2021
paddycarver
force-pushed
the
prior-state-helper-plan-modifiers
branch
from
8ddd464 to
e746c9e
Compare
|
Think I addressed the comments. Still feel good about it, @bflad? |
Fix checking attribute state to properly handle null values.
We don't want to override the optional+computed values that actually gain a config value, for example.
Co-authored-by: Brian Flad <bflad417@gmail.com>
paddycarver
force-pushed
the
prior-state-helper-plan-modifiers
branch
from
e746c9e to
b3785d9
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180
Needs careful testing.