Refactor ToTerraformValue to return a tftypes.Value. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddycarver
added
the
tech-debt
paddycarver
force-pushed
the
paddy_toterraformvalue
branch
from
4a6afc2 to
10e0034
Compare
bflad
approved these changes
Dec 13, 2021
Refactor the `attr.Value.ToTerraformValue` to return a `tftypes.Value`, which simplifies a bunch of code and makes the interface safer by allowing it to be type checked by the compiler. It did require quite a bit of refactoring of internal code, however. This also simplifies checking whether an arbitrary `attr.Value` is null or unknown considerably. Fixes #171.
paddycarver
force-pushed
the
paddy_toterraformvalue
branch
from
10e0034 to
182a41c
Compare
Co-authored-by: Brian Flad <bflad417@gmail.com>
|
Fixes look good? |
ewbankkit
added a commit
to hashicorp/terraform-provider-awscc
that referenced
this pull request
Jan 4, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
attr.Value.ToTerraformValueto return atftypes.Value,which simplifies a bunch of code and makes the interface safer by
allowing it to be type checked by the compiler. It did require quite a
bit of refactoring of internal code, however.
This also simplifies checking whether an arbitrary
attr.Valueis nullor unknown considerably.
Fixes #171.