Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plan modifiers returning warning and error diagnostics on resource destruction with Terraform 1.3 and later #409

Merged
merged 4 commits into from
Jul 11, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 8, 2022

Closes #364

…ource destruction with Terraform 1.3 and later

Reference: #364
@bflad bflad added enhancement New feature or request breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. labels Jul 8, 2022
@bflad bflad added this to the v1.0.0 milestone Jul 8, 2022
@bflad bflad requested a review from a team as a code owner July 8, 2022 13:50
bflad added a commit to hashicorp/terraform-docs-common that referenced this pull request Jul 8, 2022
…mework-only features

Reference: hashicorp/terraform-plugin-framework#396
Reference: hashicorp/terraform-plugin-framework#409

These will be included in the upcoming terraform-plugin-framework v0.10.0 release and are features not available in terraform-plugin-sdk/v2.
…ource destruction in Terraform 1.3 and later
@bflad bflad merged commit 656b447 into main Jul 11, 2022
@bflad bflad deleted the bflad-PlanResourceChange-on-destroy branch July 11, 2022 13:32
@bflad bflad modified the milestones: v1.0.0, v0.10.0 Jul 11, 2022
bflad added a commit to hashicorp/terraform-docs-common that referenced this pull request Jul 21, 2022
…mework-only features (#65)

Reference: hashicorp/terraform-plugin-framework#396
Reference: hashicorp/terraform-plugin-framework#409

These were included in the terraform-plugin-framework v0.10.0 release and are features not available in terraform-plugin-sdk/v2.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change This PR introduces a breaking change or the resolution of this issue may require a breaking change. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement PlanResourceChange on Destroy Support
2 participants