tfsdk: Additional preparations for multiple schema implementations #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #365 This is a followup to the initial schema logic migration that tries to further prepare the Go module for multiple schema implementations. - Removes unexported schema-based functions/methods from the `tfsdk` package (`pathMatches` will be handled as part of schema data internalization) - Removes `tftypes.Type` handling from schemas as `(attr.Type).TerraformType()` already does this - Tries to standardize on `Type()` for fetching framework type (`attr.Type`) information from schema types (`Attribute` will get fixed once `tfsdk.Attribute` is removed) - Tries to standardize `Schema` method signatures for framework types/diagnostics and terraform-plugin-go types/errors - Prepares `NestedAttributes` implementations for unit testing across multiple attribute implementations
bflad
commented
Aug 8, 2022
| // AttributeType returns an attr.Type corresponding to the nested attributes. | ||
| func (n UnderlyingAttributes) AttributeType() attr.Type { | ||
| // Type returns the framework type of the nested attributes. | ||
| func (n UnderlyingAttributes) Type() attr.Type { |
There was a problem hiding this comment.
This internal, but exported method was not accessible in the previous release, so updating the method name is safe. Future schema implementations will likely hide internal NestedAttributes details completely.
| if attr.GetAttributes() != nil { | ||
| attrTypes[name] = attr.GetAttributes().AttributeType() | ||
| } | ||
| attrTypes[name] = attr.FrameworkType() |
There was a problem hiding this comment.
This is a bug fix from #438, but unreleased yet, so no changelog entry necessary.
bendbennett
approved these changes
Aug 8, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #365
This is a followup to the initial schema logic migration that tries to further prepare the Go module for multiple schema implementations.
tfsdkpackage (pathMatcheswill be handled as part of schema data internalization)tftypes.Typehandling from schemas as(attr.Type).TerraformType()already does thisType()for fetching framework type (attr.Type) information from schema types (Attributewill get fixed oncetfsdk.Attributeis removed)Schemamethod signatures for framework types/diagnostics and terraform-plugin-go types/errorsNestedAttributesimplementations for unit testing across multiple attribute implementations