Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement helper/logging/NewLoggingHTTPTransport as SDKv2 #976

Closed
azrdev opened this issue Apr 10, 2024 · 3 comments
Closed

implement helper/logging/NewLoggingHTTPTransport as SDKv2 #976

azrdev opened this issue Apr 10, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@azrdev
Copy link

azrdev commented Apr 10, 2024

Module version

current framework v1.7.0

Use-cases

Logging all backend API communications for debugging (esp. during provider development) should be simple.

Attempted Solutions

one can write a request/response logger manually, but it's some dozens of sloc for a common purpose

Proposal

Implement a ready-to-use "log all requests" component, like SDKv2 provides: https://pkg.go.dev/github.com/hashicorp/terraform-plugin-sdk/v2/helper/logging#NewLoggingHTTPTransport

References

@azrdev azrdev added the enhancement New feature or request label Apr 10, 2024
@bflad
Copy link
Contributor

bflad commented Apr 10, 2024

Drive-by comment: hashicorp/terraform-plugin-log#91 is a related feature request for whomever triages this.

@bendbennett
Copy link
Contributor

Hi @azrdev 👋

Thank you for raising this issue.

This appears to be a duplicate of Consider tflog http.Transport Implementation, so I'm going to close this issue.

Please feel free to upvote Consider tflog http.Transport Implementation and we'll evaluate moving forwards with that issue on the basis of the level of community interest. Thanks.

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants