-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore MinItems and MaxItems diff in nested block #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @k-yomo 👋 Thank you so much for this fix and this appears to do what we would want here! Could you do me a favor and
- Make the same changes for
tf6muxserver
so the implementations are consistent in this regard - Update the website documentation, e.g.
website/docs/plugin/mux/combining-protocol-version-5-providers.mdx
, under the Requirements section to something similar to "All provider schemas (except blockMinItems/
MaxItems`) must match" - Create a changelog entry file, e.g.
.changelog/118.txt
with something similar to
```release-note:bug
tf5muxserver+tf6muxserver: Allow differing provider schema block `MinItems` and `MaxItems` as terraform-plugin-framework does not use those fields for configuration validation
```
Thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you @k-yomo 🚀
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Resolves #117