Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove occurrences of exported Terraform version #24

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

radeksimko
Copy link
Member

This is ready for review, but I still need to raise a separate PR for httpclient.New() to hashicorp/tf-sdk-migrator#6

I decided to move the version package under internal and change dev to sdk. That seems like the path of least resistance.

Also I still need to verify whether this updated version is picked up by providers during acceptance tests.

@radeksimko radeksimko requested review from a team August 23, 2019 15:14
@radeksimko radeksimko merged commit ea2020c into master Aug 27, 2019
@radeksimko radeksimko deleted the remove-version branch August 27, 2019 10:05
@ghost
Copy link

ghost commented Sep 27, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants