Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/schema: InternalValidate fix for configuration block type checking [v1] #426

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 30, 2020

The validation for AtLeastOneOf, ConflictsWith, ExactlyOneOf, and RequiredWith should not flag configuration block attributes without Type: TypeList and MaxItems: 1 if they are the last part of the reference.

Previously:

    --- FAIL: TestSchemaMap_InternalValidate/RequiredWith_string_syntax_with_list_configuration_block (0.00s)
        schema_test.go:5037: "RequiredWith string syntax with list configuration block": Unexpected error occurred: RequiredWith: test configuration block reference (config_block_attr) can only be used with TypeList and MaxItems: 1 configuration blocks
    --- FAIL: TestSchemaMap_InternalValidate/AtLeastOneOf_string_syntax_with_set_configuration_block (0.00s)
        schema_test.go:5037: "AtLeastOneOf string syntax with set configuration block": Unexpected error occurred: AtLeastOneOf: test configuration block reference (config_block_attr) can only be used with TypeList and MaxItems: 1 configuration blocks
...

…king

The validation for `AtLeastOneOf`, `ConflictsWith`, `ExactlyOneOf`, and `RequiredWith` should not flag configuration block attributes without `Type: TypeList` and `MaxItems: 1` if they are the last part of the reference.
@appilon appilon merged commit a840c1e into hashicorp:v1-maint Apr 30, 2020
@ghost
Copy link

ghost commented May 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants