Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of schema panic on error #455

Closed
paultyng opened this issue May 14, 2020 · 2 comments
Closed

Better handling of schema panic on error #455

paultyng opened this issue May 14, 2020 · 2 comments
Labels
enhancement New feature or request subsystem/tests Issues and feature requests related to the testing framework.

Comments

@paultyng
Copy link
Contributor

This is a follow-on to #451

We may be able to plumb a testing.T down to the ResourceData (perhaps via context.Context) and a gRPC interceptor or something. If it were available, instead of a panic the SDK could simply t.Errorf but continue execution.

Considering time and cost of acc test runs, this would probably be a more user friendly approach.
@paultyng paultyng added enhancement New feature or request testing labels May 14, 2020
@paultyng paultyng modified the milestone: v2.x (next minor) May 14, 2020
@appilon appilon mentioned this issue May 26, 2020
Merged
@paddycarver paddycarver added subsystem/tests Issues and feature requests related to the testing framework. and removed testing labels Dec 17, 2020
@bflad
Copy link
Contributor

bflad commented Feb 28, 2023

Unofficially since terraform-plugin-framework v1.0.0, there are no more plans for major refactoring of helper/schema, so closing this out. Framework based providers do not have this issue.

@bflad bflad closed this as completed Feb 28, 2023
@bflad bflad closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request subsystem/tests Issues and feature requests related to the testing framework.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paddycarver @bflad @paultyng