Avoid panics when testing nested sets of varying depth #648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a panic when I have a hierarchical attribute where the depth of the hierarchy isn't necessarily the same for all objects. The panic is caused by an out of bounds slice index in cases where you specify an attribute path greater than or equal to the deepest structure in state when using
TestCheckTypeSetElemNestedAttrs()
.example - Let's say there are groups that can have sub-groups. Your state contains 4 groups and three of them are in a chain and the other has no sub-groups:
When a unit test tries to match
TestCheckTypeSetElemNestedAttrs("groups.*.groups.*.groups.*", map[string]string{"name": expectedName})
, it will panic becausegroups.*.groups.*.groups.*
causes the check to index too far into group4.