-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce tfjsonpath
Package and Sensitive and Unknown Plan Checks
#154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Left a couple of minor comments.
The documentation is superb. I particularly like the the methodical 1-2-1 comparison of SDKv2 and framework syntax. I'me wondering whether the schema structures that are described in this context are more broadly useful in terms of providing "templates" for provider developers that are migrating from SDKv2 to the framework?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks really good, optimistically approving barring some of the below suggestions. 🚀
Co-authored-by: Brian Flad <bflad417@gmail.com>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR implements the design described in [TF-727] Terraform Plugin Testing Sensitive and Unknown Plan Checks and adds the following:
tfjsonpath
package which defines methods that allows provider developers to traverse Terraform JSON dataExpectUnknownValue()
plan check which asserts that the specified attribute is unknown in the planExpectSensitiveValue()
plan check which asserts that the specified attribute is marked sensitive in the plan