Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression by allowing providers defined at TestCase level with providers defined within TestStep.Config #177

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

bendbennett
Copy link
Contributor

Closes: #176

Prior to the changes in this PR, the following test failed:

		"config-providers-testcase-providers": {
			testStep: TestStep{
				Config: "provider abc {",
			},
			testStepConfig: "# not empty",
			testStepValidateRequest: testStepValidateRequest{
				TestCaseHasProviders: true,
			},
		},
=== NAME  TestTestStepValidate/config-providers-testcase-providers
    teststep_validate_test.go:523: unexpected error: Providers must only be specified either at the TestCase or TestStep level

Whereas the equivalent test in v1.4.0 passes:

		"config-providers-testcase-providers": {
			testStep: TestStep{
				Config: "provider abc {",
			},
			testStepValidateRequest: testStepValidateRequest{
				TestCaseHasProviders: true,
			},
		},

@bendbennett bendbennett added the bug Something isn't working label Aug 31, 2023
@bendbennett bendbennett added this to the v1.5.1 milestone Aug 31, 2023
@bendbennett bendbennett requested a review from a team as a code owner August 31, 2023 16:15
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@bendbennett bendbennett merged commit 23929ab into main Aug 31, 2023
4 checks passed
@bendbennett bendbennett deleted the bendbennett/issues-176 branch August 31, 2023 17:13
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Providers must only be specified either at the TestCase or TestStep level
3 participants