Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform 12: crlf line ending in template_body of aws_cloudformation_stack causes changes #10382

Closed
ghost opened this issue Oct 4, 2019 · 4 comments · Fixed by #14270
Closed
Labels
service/cloudformation Issues and PRs that pertain to the cloudformation service.
Milestone

Comments

@ghost
Copy link

ghost commented Oct 4, 2019

This issue was originally opened by @gokskrish as hashicorp/terraform#22986. It was migrated here as a result of the provider split. The original body of the issue is below.


Terraform Version

0.12.5

Terraform Configuration Files

Terraform 12: crlf line ending in template_body of aws_cloudformation_stack causes changes, even though all resources are upto date 

Debug Output

Crash Output

Expected Behavior

No changes

Actual Behavior

Show modification of a resource without any actual change.

Steps to Reproduce

  1. Upgrade to terraform 12.
  2. Create a aws_cloudformation_stack in a file with crlf line endings.
  3. Apply the changes
  4. Update the file to lf line endings
  5. It will keep showing one resource to modify (even after apply without further changes)

Additional Context

References

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 4, 2019
@DrFaust92 DrFaust92 added the service/cloudformation Issues and PRs that pertain to the cloudformation service. label May 21, 2020
@justinretzolk
Copy link
Member

Hey @gokskrish 👋 Thank you for taking the time to file this issue! Given that there's been a number of AWS provider releases since you initially filed it, can you confirm whether you're still experiencing this behavior?

@justinretzolk justinretzolk added waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 9, 2021
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.46.0 milestone Apr 12, 2024
@terraform-aws-provider terraform-aws-provider bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Apr 12, 2024
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cloudformation Issues and PRs that pertain to the cloudformation service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants