Added check for on_failure before resetting disable_rollback during refresh

[spavuluri]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #5204

Release note for CHANGELOG:

NONE

Output from acceptance testing:

TF_ACC=1 go test ./... -v -count 1 -parallel 1 -run=TestAccAWSCloudFormationStack_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCloudFormationStack_dataSource_basic
=== PAUSE TestAccAWSCloudFormationStack_dataSource_basic
=== RUN   TestAccAWSCloudFormationStack_dataSource_yaml
=== PAUSE TestAccAWSCloudFormationStack_dataSource_yaml
=== RUN   TestAccAWSCloudFormationStack_importBasic
=== PAUSE TestAccAWSCloudFormationStack_importBasic
=== RUN   TestAccAWSCloudFormationStack_basic
=== PAUSE TestAccAWSCloudFormationStack_basic
=== RUN   TestAccAWSCloudFormationStack_disappears
=== PAUSE TestAccAWSCloudFormationStack_disappears
=== RUN   TestAccAWSCloudFormationStack_yaml
=== PAUSE TestAccAWSCloudFormationStack_yaml
=== RUN   TestAccAWSCloudFormationStack_defaultParams
=== PAUSE TestAccAWSCloudFormationStack_defaultParams
=== RUN   TestAccAWSCloudFormationStack_allAttributes
=== PAUSE TestAccAWSCloudFormationStack_allAttributes
=== RUN   TestAccAWSCloudFormationStack_withParams
=== PAUSE TestAccAWSCloudFormationStack_withParams
=== RUN   TestAccAWSCloudFormationStack_withUrl_withParams
=== PAUSE TestAccAWSCloudFormationStack_withUrl_withParams
=== RUN   TestAccAWSCloudFormationStack_withUrl_withParams_withYaml
=== PAUSE TestAccAWSCloudFormationStack_withUrl_withParams_withYaml
=== RUN   TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate
=== PAUSE TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate
=== RUN   TestAccAWSCloudFormationStack_onFailure
=== PAUSE TestAccAWSCloudFormationStack_onFailure
=== CONT  TestAccAWSCloudFormationStack_dataSource_basic
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (73.95s)
=== CONT  TestAccAWSCloudFormationStack_onFailure
--- PASS: TestAccAWSCloudFormationStack_onFailure (54.84s)
=== CONT  TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (116.51s)
=== CONT  TestAccAWSCloudFormationStack_withUrl_withParams_withYaml
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (92.23s)
=== CONT  TestAccAWSCloudFormationStack_disappears
--- PASS: TestAccAWSCloudFormationStack_disappears (70.03s)
=== CONT  TestAccAWSCloudFormationStack_basic
--- PASS: TestAccAWSCloudFormationStack_basic (66.80s)
=== CONT  TestAccAWSCloudFormationStack_importBasic
--- PASS: TestAccAWSCloudFormationStack_importBasic (69.34s)
=== CONT  TestAccAWSCloudFormationStack_dataSource_yaml
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (71.97s)
=== CONT  TestAccAWSCloudFormationStack_withParams
--- PASS: TestAccAWSCloudFormationStack_withParams (125.73s)
=== CONT  TestAccAWSCloudFormationStack_withUrl_withParams
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (162.55s)
=== CONT  TestAccAWSCloudFormationStack_allAttributes
--- PASS: TestAccAWSCloudFormationStack_allAttributes (80.48s)
=== CONT  TestAccAWSCloudFormationStack_defaultParams
--- PASS: TestAccAWSCloudFormationStack_defaultParams (68.02s)
=== CONT  TestAccAWSCloudFormationStack_yaml
--- PASS: TestAccAWSCloudFormationStack_yaml (68.65s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1122.636s
...

[lorengordon]

I hate to ping anyone that isn't already involved with a pr, so guess I'll just drop this here and hope that activity alone might get it some attention. This patch seems pretty straightforward. Would love to see it released!

[YakDriver]

Looks good! 🎉

Output from acceptance tests (us-west-2):

--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Delete (20.33s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_DoNothing (40.19s)
--- PASS: TestAccAWSCloudFormationStack_onFailure (65.31s)
--- PASS: TestAccAWSCloudFormationStack_basic (79.48s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Rollback (82.24s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (82.54s)
--- PASS: TestAccAWSCloudFormationStack_disappears (93.00s)
--- PASS: TestAccAWSCloudFormationStack_withTransform (93.01s)
--- PASS: TestAccAWSCloudFormationStack_yaml (94.60s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (95.36s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (96.28s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (97.90s)
--- PASS: TestAccAWSCloudFormationStack_UpdateFailure (108.56s)
--- PASS: TestAccAWSCloudFormationStack_allAttributes (109.13s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (123.03s)
--- PASS: TestAccAWSCloudFormationStack_withParams (144.75s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (188.87s)

Output from acceptance tests (GovCloud):

--- PASS: TestAccAWSCloudFormationStack_CreationFailure_DoNothing (34.30s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Delete (73.62s)
--- PASS: TestAccAWSCloudFormationStack_disappears (75.29s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Rollback (77.00s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (77.31s)
--- PASS: TestAccAWSCloudFormationStack_withTransform (78.18s)
--- PASS: TestAccAWSCloudFormationStack_onFailure (82.04s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (84.17s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (85.98s)
--- PASS: TestAccAWSCloudFormationStack_basic (89.50s)
--- PASS: TestAccAWSCloudFormationStack_yaml (94.55s)
--- PASS: TestAccAWSCloudFormationStack_UpdateFailure (117.11s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (117.12s)
--- PASS: TestAccAWSCloudFormationStack_allAttributes (130.44s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (145.52s)
--- PASS: TestAccAWSCloudFormationStack_withParams (148.26s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (174.83s)

[YakDriver]

Acceptance tests are still good:

--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Delete (20.27s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_Rollback (42.10s)
--- PASS: TestAccAWSCloudFormationStack_CreationFailure_DoNothing (52.11s)
--- PASS: TestAccAWSCloudFormationStack_onFailure (74.46s)
--- PASS: TestAccAWSCloudFormationStack_disappears (80.10s)
--- PASS: TestAccAWSCloudFormationStack_allAttributes (86.98s)
--- PASS: TestAccAWSCloudFormationStack_yaml (90.33s)
--- PASS: TestAccAWSCloudFormationStack_defaultParams (93.26s)
--- PASS: TestAccAWSCloudFormationStack_withTransform (96.32s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (98.33s)
--- PASS: TestAccAWSCloudFormationStack_basic (101.58s)
--- PASS: TestAccAWSCloudFormationStack_UpdateFailure (105.52s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (111.54s)
--- PASS: TestAccAWSCloudFormationStack_dataSource_basic (135.26s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (137.47s)
--- PASS: TestAccAWSCloudFormationStack_withParams (141.33s)
--- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (155.00s)

[lorengordon]

@YakDriver There's a chance this also fixes #1807 ...

[ghost]

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.