Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_kinesis_firehose_delivery_stream to support ClusterEndpoint for ElasticSearch #10623

Closed
developerinlondon opened this issue Oct 24, 2019 · 3 comments · Fixed by #12484
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kinesis Issues and PRs that pertain to the kinesis service.
Milestone

Comments

@developerinlondon
Copy link

Currently terraform only supports creating a kinesis firehose delivery stream by specifying an elasticsearch domainARN, but for cross-account elasticsearch (released on October 8th, 2019) we need support for passing the ClusterEndpoint as described in the AWS documentation and API here:
https://docs.aws.amazon.com/firehose/latest/dev/controlling-access.html#cross-account-delivery-es (look at point 3)
https://docs.aws.amazon.com/firehose/latest/dev/controlling-access.html#using-iam-es
https://docs.aws.amazon.com/cli/latest/reference/firehose/create-delivery-stream.html
(api call supports clusterEndpoint however terraform does not it seems)

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Affected Resource(s)

  • aws_XXXXX

Terraform Configuration Files

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key: https://keybase.io/hashicorp

Debug Output

Panic Output

Expected Behavior

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 24, 2019
@ryndaniels ryndaniels added enhancement Requests to existing resources that expand the functionality or scope. service/kinesis Issues and PRs that pertain to the kinesis service. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 4, 2019
@bflad bflad added this to the v3.5.0 milestone Aug 31, 2020
@bflad
Copy link
Contributor

bflad commented Aug 31, 2020

Support for this new functionality (elasticsearch_configuration configuration block cluster_endpoint argument in the aws_kinesis_firehose_delivery_stream resource) has been merged and will release with version 3.5.0 of the Terraform AWS Provider, later this week. Thanks to @DrFaust92 for the implementation. 👍

@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kinesis Issues and PRs that pertain to the kinesis service.
Projects
None yet
3 participants