Add validation to the name of aws_elb resource.

[kangaechu]

The name property of the aws_lb resource cannot begin with internal-.

This name must be unique per region per account, can have a maximum of 32 characters, must contain only alphanumeric characters or hyphens, must not begin or end with a hyphen, and must not begin with "internal-".

https://docs.aws.amazon.com/en_us/cli/latest/reference/elbv2/create-load-balancer.html

So, I added validation to the name property to make it aware of Terraform validation.

I don't add validation into name_prefix because it is already validated to less than 6 characters.

https://github.com/terraform-providers/terraform-provider-aws/blob/dc731c277b97319ed014745222dd260e36fdb42a/aws/validators.go#L453-L456

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestValidateElbName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestValidateElbName -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestValidateElbName
--- PASS: TestValidateElbName (0.00s)
=== RUN   TestValidateElbNamePrefix
--- PASS: TestValidateElbNamePrefix (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       0.049s
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap      0.011s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags 0.022s [no tests to run]

[kangaechu]

I rebased.

Tests are still OK.

$ make testacc TESTARGS='-run=TestValidateElbName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestValidateElbName -timeout 120m
=== RUN   TestValidateElbName
--- PASS: TestValidateElbName (0.00s)
=== RUN   TestValidateElbNamePrefix
--- PASS: TestValidateElbNamePrefix (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1.659s

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[anGie44]

Thank you for this enhancement @kangaechu , LGTM 🚀 I've additionally extended the validation to the name_prefix argument as it should prevent the internal- prefix from use in name generation.

Output of unit tests:

--- PASS: TestValidName (0.00s)
--- PASS: TestValidNamePrefix (0.00s)

[github-actions]

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.