Add aws_dedicated_host for terraform-provider-aws #10817

rpomykala · 2019-11-09T08:43:28Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:


FEATURES:
New Resource: aws_dedicated_host (#10752)

Output from acceptance testing:

➜ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDedicatedHostDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDedicatedHostDataSource_basic -timeout 120m
=== RUN   TestAccAWSDedicatedHostDataSource_basic
=== PAUSE TestAccAWSDedicatedHostDataSource_basic
=== CONT  TestAccAWSDedicatedHostDataSource_basic
--- PASS: TestAccAWSDedicatedHostDataSource_basic (37.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.065s
...

khyew

Mostly style/idiomatic Go stuff; feel free to address at your leisure. One question about a potential nil pointer situation that I'm not sure about-- if it's a non-issue then feel free to resolve.

Caveat: I'm not super familiar with this codebase do I didn't do a very thorough review of the logic (I'll leave that to the project maintainers and contributors) but nothing stands out to me. Good luck with the PR!

aws/data_source_aws_dedicated_host.go

bryantbiggs · 2020-02-24T17:08:42Z

@rpomykala / @khyew - any update on this PR? we have a need for dedicated hosts and would love to have this make its way into the provider. let me know if there is anything left to resolve and we can pitch in to get it across the line

rpomykala · 2020-04-10T19:20:30Z

Sorry for long time of inactivity, I have updated the module with MVP required to make it all work for anyone who needs it urgently.

hotdawg789 · 2020-04-14T16:29:05Z

Excited to see this feature, can get rid of my boto/python pre tf build scripts :-)

aws/resource_aws_dedicated_host.go

aws/resources_aws_dedicated_host_test.go

DrFaust92

more comments:

the resources_aws_dedicated_host_test needs to be rename to data_source_aws_dedicate_host_test
add docs for data source
add tests for the resource

aws/data_source_aws_dedicated_host.go

aws/resource_aws_dedicated_host.go

aws/data_source_aws_dedicated_host.go

aws/resources_aws_dedicated_host_test.go

website/docs/r/dedicated_host.html.markdown

aws/resources_aws_dedicated_host_test.go

bryantbiggs · 2020-05-07T01:22:09Z

@khyew / @DrFaust92 - anything we can do to help @rpomykala get this merged? they have updated several times but still no signs of when it will be ready to merge

teamterraform · 2020-08-18T20:27:35Z

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Action Required: Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Action Required: Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

vasylenko · 2020-12-03T21:22:50Z

This feature will be handy in the context of the recent release of macOS support for EC2!

keith · 2021-08-19T21:49:03Z

We'd love to see this for ec2 macOS support as well!

…utes

ewbankkit

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccAWSEc2Host_\|TestAccAWSEc2HostDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2Host_\|TestAccAWSEc2HostDataSource_ -timeout 180m
=== RUN   TestAccAWSEc2HostDataSource_basic
=== PAUSE TestAccAWSEc2HostDataSource_basic
=== RUN   TestAccAWSEc2HostDataSource_Filter
=== PAUSE TestAccAWSEc2HostDataSource_Filter
=== RUN   TestAccAWSEc2Host_basic
=== PAUSE TestAccAWSEc2Host_basic
=== RUN   TestAccAWSEc2Host_disappears
=== PAUSE TestAccAWSEc2Host_disappears
=== RUN   TestAccAWSEc2Host_InstanceFamily
=== PAUSE TestAccAWSEc2Host_InstanceFamily
=== RUN   TestAccAWSEc2Host_Tags
=== PAUSE TestAccAWSEc2Host_Tags
=== CONT  TestAccAWSEc2HostDataSource_basic
=== CONT  TestAccAWSEc2Host_InstanceFamily
=== CONT  TestAccAWSEc2Host_basic
=== CONT  TestAccAWSEc2HostDataSource_Filter
=== CONT  TestAccAWSEc2Host_disappears
=== CONT  TestAccAWSEc2Host_Tags
--- PASS: TestAccAWSEc2Host_disappears (19.99s)
--- PASS: TestAccAWSEc2HostDataSource_basic (24.32s)
--- PASS: TestAccAWSEc2HostDataSource_Filter (24.35s)
--- PASS: TestAccAWSEc2Host_basic (26.18s)
--- PASS: TestAccAWSEc2Host_InstanceFamily (37.39s)
--- PASS: TestAccAWSEc2Host_Tags (49.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	52.966s

GovCloud

% make testacc TESTARGS='-run=TestAccAWSEc2Host_\|TestAccAWSEc2HostDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2Host_\|TestAccAWSEc2HostDataSource_ -timeout 180m
=== RUN   TestAccAWSEc2HostDataSource_basic
=== PAUSE TestAccAWSEc2HostDataSource_basic
=== RUN   TestAccAWSEc2HostDataSource_Filter
=== PAUSE TestAccAWSEc2HostDataSource_Filter
=== RUN   TestAccAWSEc2Host_basic
=== PAUSE TestAccAWSEc2Host_basic
=== RUN   TestAccAWSEc2Host_disappears
=== PAUSE TestAccAWSEc2Host_disappears
=== RUN   TestAccAWSEc2Host_InstanceFamily
=== PAUSE TestAccAWSEc2Host_InstanceFamily
=== RUN   TestAccAWSEc2Host_Tags
=== PAUSE TestAccAWSEc2Host_Tags
=== CONT  TestAccAWSEc2HostDataSource_basic
=== CONT  TestAccAWSEc2Host_InstanceFamily
=== CONT  TestAccAWSEc2Host_Tags
=== CONT  TestAccAWSEc2Host_basic
=== CONT  TestAccAWSEc2Host_disappears
=== CONT  TestAccAWSEc2HostDataSource_Filter
=== CONT  TestAccAWSEc2HostDataSource_basic
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error allocating EC2 Host: UnsupportedHostConfiguration: The requested configuration is currently not supported. Please check the documentation for supported configurations.
        	status code: 400, request id: e615d2d2-ee12-45fc-8329-744e3d386083
        
          with aws_ec2_host.test,
          on terraform_plugin_test.tf line 11, in resource "aws_ec2_host" "test":
          11: resource "aws_ec2_host" "test" {
        
=== CONT  TestAccAWSEc2Host_disappears
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error allocating EC2 Host: UnsupportedHostConfiguration: The requested configuration is currently not supported. Please check the documentation for supported configurations.
        	status code: 400, request id: b74fbd7e-fae7-45bb-bf83-4d90c7d896b6
        
          with aws_ec2_host.test,
          on terraform_plugin_test.tf line 11, in resource "aws_ec2_host" "test":
          11: resource "aws_ec2_host" "test" {
        
=== CONT  TestAccAWSEc2Host_Tags
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error allocating EC2 Host: UnsupportedHostConfiguration: The requested configuration is currently not supported. Please check the documentation for supported configurations.
        	status code: 400, request id: 04b7e281-e827-40e5-beeb-470525696ea9
        
          with aws_ec2_host.test,
          on terraform_plugin_test.tf line 11, in resource "aws_ec2_host" "test":
          11: resource "aws_ec2_host" "test" {
        
=== CONT  TestAccAWSEc2HostDataSource_Filter
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error allocating EC2 Host: UnsupportedHostConfiguration: The requested configuration is currently not supported. Please check the documentation for supported configurations.
        	status code: 400, request id: 66f9b95e-efa0-4673-b8d2-212065e7ec3a
        
          with aws_ec2_host.test,
          on terraform_plugin_test.tf line 11, in resource "aws_ec2_host" "test":
          11: resource "aws_ec2_host" "test" {
        
=== CONT  TestAccAWSEc2Host_basic
    provider_test.go:1166: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error allocating EC2 Host: UnsupportedHostConfiguration: The requested configuration is currently not supported. Please check the documentation for supported configurations.
        	status code: 400, request id: 200aaaf1-7dfd-4ed5-8642-0918037a89cf
        
          with aws_ec2_host.test,
          on terraform_plugin_test.tf line 11, in resource "aws_ec2_host" "test":
          11: resource "aws_ec2_host" "test" {
        
--- SKIP: TestAccAWSEc2Host_Tags (12.93s)
--- SKIP: TestAccAWSEc2Host_disappears (12.99s)
--- SKIP: TestAccAWSEc2HostDataSource_basic (13.08s)
--- SKIP: TestAccAWSEc2Host_basic (13.14s)
--- SKIP: TestAccAWSEc2HostDataSource_Filter (13.20s)
--- PASS: TestAccAWSEc2Host_InstanceFamily (42.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	47.515s

ewbankkit · 2021-09-24T21:21:17Z

@rpomykala Thanks for the contribution 🎉 👏.

I went ahead and renamed the resource to aws_ec2_host to match our preferred naming standards.

github-actions · 2021-10-07T17:59:52Z

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-06-17T02:36:16Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

rpomykala requested a review from a team November 9, 2019 08:43

khyew approved these changes Nov 11, 2019

View reviewed changes

ghost added the documentation Introduces or discusses updates to documentation. label Nov 12, 2019

bflad added new-data-source Introduces a new data source. new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 24, 2020

ghost added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Apr 10, 2020

rpomykala changed the title ~~[WIP] Add aws_dedicated_host for terraform-provider-aws~~ Add aws_dedicated_host for terraform-provider-aws Apr 10, 2020

rpomykala mentioned this pull request Apr 14, 2020

Add ability to allocate dedicated hosts for VMs #10752

Closed

DrFaust92 suggested changes Apr 14, 2020

View reviewed changes

DrFaust92 suggested changes Apr 16, 2020

View reviewed changes

DrFaust92 reviewed Apr 16, 2020

View reviewed changes

aws/resources_aws_dedicated_host_test.go Outdated Show resolved Hide resolved

anGie44 force-pushed the master branch from 6c6566f to 081bf57 Compare June 29, 2020 16:14

Base automatically changed from master to main January 23, 2021 00:56

breathingdust requested a review from a team as a code owner January 23, 2021 00:56

rpomykala added 2 commits September 23, 2021 14:04

Added initial commit

ef2934a

Added pointer to a hostID

4f3c514

rpomykala and others added 20 commits September 23, 2021 14:05

Docscheck fix

302df62

Final fixes for linting

77bfd7e

AWSerr refactor

b4da87b

extraneous forcenew removed

b65f9c5

Add validatefunc

7460312

removed incompatible type

b9a4d61

removed incompatible type

6d95478

Refactored acc to conversations

1666112

Improved testing for data_source and added web resource, added attrib…

e9be3b5

…utes

Add missing attribute

104d903

Added resource_aws_dedicated_host_test.go

2159ccb

Migrate to v2 SDK

92dffe8

Corrections after rebase.

bd5387e

'aws_dedicated_host' -> 'aws_ec2_host'; Rename files.

6ebe19d

'aws_dedicated_host' -> 'aws_ec2_host'; Rename functions and resources.

e006f22

r/aws_ec2_host: Tidy up attributes.

7596cbb

r/aws_ec2_host: Simplify.

99eeb77

r/aws_ec2_host: Get acceptance tests working.

936a572

Add CHANGELOG entry.

fe47867

d/aws_ec2_host: Get acceptance tests working.

f190485

ewbankkit force-pushed the dedicated-host-branch branch from c9557f1 to f190485 Compare September 24, 2021 21:18

ewbankkit approved these changes Sep 24, 2021

View reviewed changes

ewbankkit added 2 commits September 24, 2021 17:26

Fix terrafmt errors.

7cd20a9

Fix semgrep error.

2e7a7a4

ewbankkit merged commit 47bf15a into hashicorp:main Sep 27, 2021

github-actions bot added this to the v3.61.0 milestone Sep 27, 2021

github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add aws_dedicated_host for terraform-provider-aws #10817

Add aws_dedicated_host for terraform-provider-aws #10817

rpomykala commented Nov 9, 2019 •

edited by ewbankkit

Loading

khyew left a comment

bryantbiggs commented Feb 24, 2020

rpomykala commented Apr 10, 2020

hotdawg789 commented Apr 14, 2020

DrFaust92 left a comment

bryantbiggs commented May 7, 2020

teamterraform commented Aug 18, 2020

vasylenko commented Dec 3, 2020

keith commented Aug 19, 2021

ewbankkit left a comment

ewbankkit commented Sep 24, 2021

github-actions bot commented Oct 7, 2021

github-actions bot commented Jun 17, 2022

Add aws_dedicated_host for terraform-provider-aws #10817

Add aws_dedicated_host for terraform-provider-aws #10817

Conversation

rpomykala commented Nov 9, 2019 • edited by ewbankkit Loading

Community Note

khyew left a comment

Choose a reason for hiding this comment

bryantbiggs commented Feb 24, 2020

rpomykala commented Apr 10, 2020

hotdawg789 commented Apr 14, 2020

DrFaust92 left a comment

Choose a reason for hiding this comment

bryantbiggs commented May 7, 2020

teamterraform commented Aug 18, 2020

Notification of Recent and Upcoming Changes to Contributions

Action Required: Terraform 0.12 Syntax

Action Required: Terraform Plugin SDK Version 2

Action Required: Removal of website/aws.erb File

Upcoming Change of Git Branch Naming

Upcoming Change of GitHub Organization

vasylenko commented Dec 3, 2020

keith commented Aug 19, 2021

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Sep 24, 2021

github-actions bot commented Oct 7, 2021

github-actions bot commented Jun 17, 2022

rpomykala commented Nov 9, 2019 •

edited by ewbankkit

Loading