Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda support for Java 11, Node.js 12 and Python 3.8 #10919

Closed
ewbankkit opened this issue Nov 19, 2019 · 11 comments · Fixed by #10938
Closed

AWS Lambda support for Java 11, Node.js 12 and Python 3.8 #10919

ewbankkit opened this issue Nov 19, 2019 · 11 comments · Fixed by #10938
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Nov 19, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

You can now develop AWS Lambda functions using Java 11.
You can now author your AWS Lambda functions in Node.js 12.
You can now develop your AWS Lambda functions using Python 3.8.

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_lambda_function" "example" {
  runtime = "python3.8"
}

References

Announcements:

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 19, 2019
@ghost ghost added the service/lambda Issues and PRs that pertain to the lambda service. label Nov 19, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 19, 2019
@ewbankkit
Copy link
Contributor Author

As of AWS SDK v1.25.37 there are no SDK constants for these new runtime values.

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Nov 19, 2019
@DarkMukke
Copy link

Is the fix for NodeJS not just very similar to 6d39f61 ?

@cakejelly
Copy link

cakejelly commented Nov 19, 2019

@ewbankkit If I understand correctly then this would mean that we just need to drop the runtime validations completely from this provider and it should work. Or am I missing something?

@DrFaust92
Copy link
Collaborator

@ewbankkit, it seems that v1.25.38 adds this

@ewbankkit
Copy link
Contributor Author

@DrFaust92 Indeed it does; Thanks.
Requires:

@bflad bflad added this to the v2.39.0 milestone Nov 19, 2019
@mischuler
Copy link

@ewbankkit
Can we also add aws_lambda_layer_version as an affected resource? It also requires a runtime input.

resource "aws_lambda_layer_version" "imagemagick_layer" {
  filename   = "../layers-files/vdem-imagemagick-layer.zip"
  layer_name = "node12-imagemagick-layer"

  source_code_hash = "${filebase64sha256("../layers-files/node12-imagemagick-layer.zip")}"

  compatible_runtimes = ["nodejs12 .x"]
}

Error: aws_lambda_layer_version.imagemagick_layer: expected compatible_runtimes.0 to be one of [dotnetcore1.0 dotnetcore2.0 dotnetcore2.1 go1.x java8 nodejs4.3 nodejs4.3-edge nodejs6.10 nodejs8.10 nodejs10.x provided python2.7 python3.6 python3.7 ruby2.5], got nodejs12.x

@ewbankkit
Copy link
Contributor Author

ewbankkit commented Nov 20, 2019

@mischuler Added aws_lambda_layer_version as affected resource (and data source); Thanks.
Also added a note to the PR - #10938.

@bflad
Copy link
Contributor

bflad commented Nov 20, 2019

Support for aws_lambda_function has been merged and will release in version 2.39.0 of the Terraform AWS Provider, likely tomorrow. Will reopen to allow for aws_lambda_layer_version implementation.

@bflad bflad reopened this Nov 20, 2019
@bflad
Copy link
Contributor

bflad commented Nov 21, 2019

Hi folks 👋 The runtime validation is actually shared between both aws_lambda_function and aws_lambda_layer_version resources and we have verified the updated validation in the latter resource as well. The CHANGELOG is updated to reflect both these resources receiving this update and this will release later today in version 2.39.0. 👍

@bflad bflad closed this as completed Nov 21, 2019
@ghost
Copy link

ghost commented Nov 21, 2019

This has been released in version 2.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.
Projects
None yet
6 participants