Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_fsx_windows_file_system minimum storage capacity does not match console #11247

Closed
pmcevoy opened this issue Dec 11, 2019 · 5 comments · Fixed by #11272
Closed

aws_fsx_windows_file_system minimum storage capacity does not match console #11247

pmcevoy opened this issue Dec 11, 2019 · 5 comments · Fixed by #11272
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service.
Milestone

Comments

@pmcevoy
Copy link

pmcevoy commented Dec 11, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

 [master ≡ +0 ~1 -0 !]> terraform -v
Terraform v0.12.15
+ provider.aws v2.41.0

Affected Resource(s)

  • aws_fsx_windows_file_system

Terraform Configuration Files

resource "aws_fsx_windows_file_system" "filecluster" {
	storage_capacity    = 32
	throughput_capacity = 128
  active_directory_id = data.terraform_remote_state.directory.outputs.directory_id

  subnet_ids          = [
		data.aws_subnet.service[0].id
	]

  security_group_ids  = [
    data.aws_security_group.vpc.id
  ]
}

Expected Behavior

Support storage capacity as per GUI console:

Minimum 32 GiB; Maximum 65536 GiB

Actual Behavior

Error: expected storage_capacity to be in the range (300 - 65536), got 32

References

For Windows file systems, valid values are 32 GiB - 65,536 GiB.

@ghost ghost added the service/fsx Issues and PRs that pertain to the fsx service. label Dec 11, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 11, 2019
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 11, 2019
@bflad
Copy link
Contributor

bflad commented Dec 11, 2019

The lower size is part of an enhancement the service rolled out last month: https://aws.amazon.com/about-aws/whats-new/2019/11/amazon-fsx-for-windows-file-server-reduces-the-minimum-size-for-file-systems-from-300-gbs-to-32-gbs/

@mrgiles
Copy link
Contributor

mrgiles commented Dec 12, 2019

@pmcevoy, @bflad, I wrote a patch for this (#11272), hope it works. It's my first contribution here. I wasn't familiar with the test suite but it seemed to work in the second iteration (I closed the first PR).

@bflad
Copy link
Contributor

bflad commented Dec 18, 2019

Validation for the lower storage_capacity minimum value has been merged and will release with version 2.43.0 of the Terraform AWS Provider, tomorrow. Thanks to @mrgiles for the implementation. 👍

@ghost
Copy link

ghost commented Dec 19, 2019

This has been released in version 2.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants