Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cognito feature to enable PreventUserExistenceErrors for user pool clients. #11340

Closed
realanmup opened this issue Dec 18, 2019 · 6 comments · Fixed by #11604
Closed

Cognito feature to enable PreventUserExistenceErrors for user pool clients. #11340

realanmup opened this issue Dec 18, 2019 · 6 comments · Fixed by #11604
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Milestone

Comments

@realanmup
Copy link

realanmup commented Dec 18, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Cognito user pools now support a flag that prevents Cognito from raising errors that can be used to verify the existence of a user. This flag is currently set to legacy/false. It should be set to true to improve the security of application from fishing attacks. Till now, i couldn't find any key to work on that.
There is note from aws that:

After January 1st 2020, the value of PreventUserExistenceErrors will default to ENABLED for newly created User Pool Clients if no value is provided.

but we should be able to control it anyways.

New or Affected Resource(s)

  • aws_cognito_user_pool_client

Potential Terraform Configuration

prevent_user_existence_errors = "enabled" | "legacy"

References

@realanmup realanmup added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 18, 2019
@ghost ghost added the service/cognito label Dec 18, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 18, 2019
@hildoer
Copy link

hildoer commented Dec 20, 2019

+1

@claydanford
Copy link
Contributor

@realanmup @hildoer Please see #11604

@alkis-hexa
Copy link

+1

@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Mar 17, 2020
@bflad bflad self-assigned this Mar 17, 2020
@bflad bflad added this to the v2.54.0 milestone Mar 17, 2020
@bflad
Copy link
Contributor

bflad commented Mar 17, 2020

Support for this functionality has been merged and will release with version 2.54.0 of the Terraform AWS Provider, later this week. Thanks to @claydanford for the implementation. 👍

@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants