Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_transfer_server: support Elastic IPs #11569

Closed
marcoreni opened this issue Jan 12, 2020 · 3 comments · Fixed by #12599
Closed

aws_transfer_server: support Elastic IPs #11569

marcoreni opened this issue Jan 12, 2020 · 3 comments · Fixed by #12599
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service.
Milestone

Comments

@marcoreni
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS Transfer now supports Elastic IPs. With this, there's no more need to create a NLB to expose the server in known IP address.

Terraform provider should support these as well.

New or Affected Resource(s)

  • aws_transfer_server

Potential Terraform Configuration

resource "aws_transfer_server" "foo" {
  endpoint_details {
    address_allocation_ids = ["eipalloc-..."]
    subnet_ids = ["subnet-..."]
    vpc_id = "vpc-..."
    vpc_endpoint_id = "vpce-..."
  }
  endpoint_type = "VPC"
}

References

Announcement: https://aws.amazon.com/about-aws/whats-new/2020/01/aws-transfer-for-sftp-supports-vpc-security-groups-and-elastic-ip-addresses/
Docs: https://docs.aws.amazon.com/transfer/latest/userguide/create-sftp-server-in-vpc.html
Requires AWS SDK v1.28.0:

@marcoreni marcoreni added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 12, 2020
@ghost ghost added the service/transfer Issues and PRs that pertain to the transfer service. label Jan 12, 2020
@marcoreni marcoreni changed the title aws_transfer_server: support Elastic IPs and Security Groups aws_transfer_server: support Elastic IPs Jan 12, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 12, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Jan 16, 2020
@bflad bflad self-assigned this Sep 24, 2020
@bflad bflad added this to the v3.8.0 milestone Sep 24, 2020
@bflad
Copy link
Contributor

bflad commented Sep 24, 2020

Support for the VPC endpoint type (including additional endpoint_details arguments to support EIPs) has been merged and will release with version 3.8.0 of the Terraform AWS Provider, likely later today. Thanks to @sshearn for the implementation. 👍

@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service.
Projects
None yet
2 participants