Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Lambda API change #11609

Closed
shadycuz opened this issue Jan 15, 2020 · 2 comments
Closed

Upcoming Lambda API change #11609

shadycuz opened this issue Jan 15, 2020 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.

Comments

@shadycuz
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS will be changing how lambda's in a VPC work.
https://aws.amazon.com/blogs/compute/coming-soon-updated-lambda-states-lifecycle-for-vpc-networking/

New or Affected Resource(s)

  • aws_lambda_function

Potential Terraform Configuration

resource "aws_lambda_function" "pre_signup_lambda" {
  filename      = var.pre_signup_archive
  function_name = "${module.default_label.id}-Pre-Signup"
  description   = "Lambda function for pre-signup for ${var.name} in ${var.environment} environment"
  role          = aws_iam_role.lambda.arn
  handler       = "lambdas/preSignup.handler"

  vpc_config {
      subnet_ids         = module.vpc.private_subnets
      security_group_ids = [aws_security_group.fusion_lambda.id]
  }

  runtime     = "nodejs10.x"
  timeout     = 6
  memory_size = 240
}

References

I read through the code and I don't see anywhere that the status of the lambda is taken into consideration. In the lambda read function we could probably check if the lambda is deployed into a VPC and if so we could do a retry operation until the status comes back as "Active".

@shadycuz shadycuz added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 15, 2020
@ghost ghost added the service/lambda Issues and PRs that pertain to the lambda service. label Jan 15, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 15, 2020
@bflad
Copy link
Contributor

bflad commented Jan 16, 2020

Hi @shadycuz 👋 Thank you for writing this up.

This should already be handled by #11016, which was released in version 2.40.0 of the Terraform AWS Provider. If there are additional changes needed, please let us know. Thanks.

@bflad bflad closed this as completed Jan 16, 2020
@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.
Projects
None yet
Development

No branches or pull requests

3 participants