Pinpoint SMS sender ID not controlled by terraform

[eladazary]

In order to configure the SMS sender ID in Pinpoint App I've created "aws_pinpoint_sms_channel" resource and set the sender_id param.
After the app was created it didn't changed the sender ID and set it as the AWS default value.

Please assist.

[bflad]

Looks like this is showing up in the resource acceptance testing here on update:

=== CONT  TestAccAWSPinpointSMSChannel_full
resource_aws_pinpoint_sms_channel_test.go:61: Step 3/3 error: Check failed: Check 2/6 error: aws_pinpoint_sms_channel.test_sms_channel: Attribute 'sender_id' expected "1234", got ""
--- FAIL: TestAccAWSPinpointSMSChannel_full (69.48s)

The code is only passing sender_id if it has a change on update:

terraform-provider-aws/aws/resource_aws_pinpoint_sms_channel.go

Lines 62 to 64 in 075f130

	if d.HasChange("sender_id") {
	params.SenderId = aws.String(d.Get("sender_id").(string))
	}

Which seems incorrect as evidenced by the test -- the UpdateSmsSettings API call does not have the parameter and immediately after the GetSmsSettings API call has the SenderId unexpectedly removed.

[ghost]

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!