Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch_source block to resource_aws_ssm_patch_baseline #11879

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

jdheyburn
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #4748

Release note for CHANGELOG:

ENHANCEMENTS:
resource/aws_ssm_patch_baseline: Add patch_source configuration block [#4748]

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMPatchBaseline*'            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSSMPatchBaseline* -timeout 120m
=== RUN   TestAccAWSSSMPatchBaseline_basic
=== PAUSE TestAccAWSSSMPatchBaseline_basic
=== RUN   TestAccAWSSSMPatchBaseline_tags
=== PAUSE TestAccAWSSSMPatchBaseline_tags
=== RUN   TestAccAWSSSMPatchBaseline_disappears
=== PAUSE TestAccAWSSSMPatchBaseline_disappears
=== RUN   TestAccAWSSSMPatchBaseline_OperatingSystem
=== PAUSE TestAccAWSSSMPatchBaseline_OperatingSystem
=== RUN   TestAccAWSSSMPatchBaseline_PatchSources
=== PAUSE TestAccAWSSSMPatchBaseline_PatchSources
=== CONT  TestAccAWSSSMPatchBaseline_basic
=== CONT  TestAccAWSSSMPatchBaseline_OperatingSystem
=== CONT  TestAccAWSSSMPatchBaseline_PatchSources
=== CONT  TestAccAWSSSMPatchBaseline_tags
=== CONT  TestAccAWSSSMPatchBaseline_disappears
--- PASS: TestAccAWSSSMPatchBaseline_disappears (15.52s)
--- PASS: TestAccAWSSSMPatchBaseline_basic (33.65s)
--- PASS: TestAccAWSSSMPatchBaseline_PatchSources (34.87s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (34.96s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (47.15s)

@jdheyburn jdheyburn requested a review from a team February 4, 2020 08:38
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Feb 4, 2020
Base automatically changed from master to main January 23, 2021 00:57
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:57
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 12, 2021
@bflad
Copy link
Contributor

bflad commented Feb 12, 2021

Hi @jdheyburn 👋 Apologies for the delayed review here and thank you for working on this. This is looking good. I will be fixing the merge conflicts likely due to merging the other big pull request to this resource and working on getting this in (with the blocks named source instead of patch_source to better align with the API).

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you, @jdheyburn 🚀

With source rename:

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSSSMPatchBaseline_disappears (13.63s)
--- PASS: TestAccAWSSSMPatchBaseline_ApprovedPatchesNonSec (16.37s)
--- PASS: TestAccAWSSSMPatchBaseline_RejectPatchesAction (17.55s)
--- PASS: TestAccAWSSSMPatchBaseline_basic (26.22s)
--- PASS: TestAccAWSSSMPatchBaseline_Sources (27.70s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (28.85s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (35.86s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSSSMPatchBaseline_disappears (16.44s)
--- PASS: TestAccAWSSSMPatchBaseline_ApprovedPatchesNonSec (22.40s)
--- PASS: TestAccAWSSSMPatchBaseline_RejectPatchesAction (22.56s)
--- PASS: TestAccAWSSSMPatchBaseline_basic (33.18s)
--- PASS: TestAccAWSSSMPatchBaseline_Sources (35.37s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (35.76s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (47.99s)

@bflad bflad merged commit 61b6c1d into hashicorp:main Feb 12, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 12, 2021
@jdheyburn
Copy link
Contributor Author

Thanks @bflad! I appreciate the merge 😃

@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use patch source(s) with ssm_patch_baseline
2 participants