-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patch_source block to resource_aws_ssm_patch_baseline #11879
Conversation
Hi @jdheyburn 👋 Apologies for the delayed review here and thank you for working on this. This is looking good. I will be fixing the merge conflicts likely due to merging the other big pull request to this resource and working on getting this in (with the blocks named |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you, @jdheyburn 🚀
With source
rename:
Output from acceptance testing in AWS Commercial:
--- PASS: TestAccAWSSSMPatchBaseline_disappears (13.63s)
--- PASS: TestAccAWSSSMPatchBaseline_ApprovedPatchesNonSec (16.37s)
--- PASS: TestAccAWSSSMPatchBaseline_RejectPatchesAction (17.55s)
--- PASS: TestAccAWSSSMPatchBaseline_basic (26.22s)
--- PASS: TestAccAWSSSMPatchBaseline_Sources (27.70s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (28.85s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (35.86s)
Output from acceptance testing in AWS GovCloud (US):
--- PASS: TestAccAWSSSMPatchBaseline_disappears (16.44s)
--- PASS: TestAccAWSSSMPatchBaseline_ApprovedPatchesNonSec (22.40s)
--- PASS: TestAccAWSSSMPatchBaseline_RejectPatchesAction (22.56s)
--- PASS: TestAccAWSSSMPatchBaseline_basic (33.18s)
--- PASS: TestAccAWSSSMPatchBaseline_Sources (35.37s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (35.76s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (47.99s)
Thanks @bflad! I appreciate the merge 😃 |
This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #4748
Release note for CHANGELOG:
Output from acceptance testing: