Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate new AWS FSx persistent features into aws_fsx_lustre_file_system resource #12181

Closed
aclaypool opened this issue Feb 26, 2020 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service.
Milestone

Comments

@aclaypool
Copy link

aclaypool commented Feb 26, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS has released persistent file systems for AWS FSx Lustre. Current terraform provider support is only for the "Scratch" file systems. If aws_fsx_lustre_file_system could be updated to support specifying a persistent file system and any additional required resources.

New or Affected Resource(s)

aws_fsx_lustre_file_system

Potential Terraform Configuration

resource "aws_fsx_lustre_file_system" "fsx" {
   import_path                   = "s3://path"
   storage_capacity           = 3600
   subnet_ids                     = ["..."] . #now supports more than one
   security_group_ids        = ["..."]
   weekly_maintenance_start_time = "5:04:00"
   deployment_type           "persistent_1|scratch_1|scratch_2"
   encryption_key             = "alias of encryption key"
}

References

https://aws.amazon.com/about-aws/whats-new/2020/02/amazon-fsx-lustre-launches-persistent-file-systems-scratch-file-systems-supports-kms-encryption-in-transit/

https://docs.aws.amazon.com/cli/latest/reference/fsx/create-file-system.html

https://docs.aws.amazon.com/fsx/latest/APIReference/API_CreateFileSystem.html

@aclaypool aclaypool added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 26, 2020
@ghost ghost added the service/fsx Issues and PRs that pertain to the fsx service. label Feb 26, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 26, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Feb 26, 2020
@mtpdt
Copy link
Contributor

mtpdt commented Jun 5, 2020

I've opened a PR that adds this feature. It's missing the encryption_key field that you requested, but that can be easily added in a subsequent PR.

@bflad
Copy link
Contributor

bflad commented Jul 31, 2020

The deployment_type handling has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@bflad bflad closed this as completed Jul 31, 2020
@ghost
Copy link

ghost commented Aug 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service.
Projects
None yet
Development

No branches or pull requests

4 participants