Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_storagegateway_smb_file_share: Add support for admin_user_list #12196

Merged
merged 3 commits into from
Sep 21, 2020

Conversation

Andrew-Kulpa
Copy link
Contributor

@Andrew-Kulpa Andrew-Kulpa commented Feb 27, 2020

This adds support for specifying a Storage Gateway SMB File Share admin user list. There was already support for invalid and valid user lists, but not an admin user list.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12255

Release note for CHANGELOG:

resource/aws_storagegateway_smb_file_share: Add support for `admin_user_list` parameter

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewaySmbFileShare_AdminUserList'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSStorageGatewaySmbFileShare_AdminUserList -timeout 120m
=== RUN   TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== PAUSE TestAccAWSStorageGatewaySmbFileShare_AdminUserList
=== CONT  TestAccAWSStorageGatewaySmbFileShare_AdminUserList
--- PASS: TestAccAWSStorageGatewaySmbFileShare_AdminUserList (841.71s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       843.095s

@Andrew-Kulpa Andrew-Kulpa requested a review from a team February 27, 2020 14:43
@Andrew-Kulpa
Copy link
Contributor Author

Why did Hashibot not look at this?

@Andrew-Kulpa Andrew-Kulpa changed the title r/aws_storagegateway_smb_file_share: Add support for admin_user_list resource/aws_storagegateway_smb_file_share: Add support for admin_user_list Mar 4, 2020
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service. labels May 31, 2020
@bflad
Copy link
Contributor

bflad commented Aug 20, 2020

Hi @Andrew-Kulpa 👋 Thank you for submitting this. Please see the repository FAQ for additional information about the review process. Overall this contribution looks to be on the right track, it just needs the merge conflicts handled then we can double check the testing and get this merged. 👍

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Aug 20, 2020
@bflad bflad self-assigned this Sep 18, 2020
@bflad bflad added this to the v3.8.0 milestone Sep 18, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Andrew-Kulpa 👋 Since we didn't hear back from you we went ahead and fixed the merge conflicts so this can be pulled in. Thank you 🚀

Output from acceptance testing:

--- PASS: TestAccAWSStorageGatewaySmbFileShare_AdminUserList (905.74s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_audit (352.38s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_ActiveDirectory (805.96s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Authentication_GuestAccess (233.19s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_cacheAttributes (452.08s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_caseSensitivity (377.34s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_DefaultStorageClass (318.63s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_disappears (244.85s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_GuessMIMETypeEnabled (315.80s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_InvalidUserList (916.69s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSEncrypted (241.10s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_KMSKeyArn (418.40s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ObjectACL (302.70s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ReadOnly (302.46s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_RequesterPays (293.18s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_smb_acl (959.71s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_Tags (300.74s)
--- PASS: TestAccAWSStorageGatewaySmbFileShare_ValidUserList (931.02s)

bflad added a commit that referenced this pull request Sep 21, 2020
@bflad bflad merged commit 5b7454d into hashicorp:master Sep 21, 2020
@Andrew-Kulpa
Copy link
Contributor Author

Sorry, I must've missed that notification. Thanks a bunch! 😅

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 21, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AWS Storage GW SMB File Share Admin User List
3 participants