Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: WAF Subscribed rule group #12407

Closed
haidaraM opened this issue Mar 16, 2020 · 3 comments · Fixed by #10563
Closed

New Data Source: WAF Subscribed rule group #12407

haidaraM opened this issue Mar 16, 2020 · 3 comments · Fixed by #10563
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/waf Issues and PRs that pertain to the waf service.
Milestone

Comments

@haidaraM
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New data sources to fetch the waf (and waf regional) subscribed rule groups. These rule groups can be subscribed in the market place.

Two data sources may be required because the same rule doesn't have the same ID depending on when using it with a regional web acl or a global web acl.

$ aws waf-regional list-subscribed-rule-groups
{
    "RuleGroups": [
        {
            "RuleGroupId": "490f6909-95a7-4890-8ef7-cd2d2bb75950",
            "Name": "Fortinet Managed Rules for AWS WAF - Complete OWASP Top 10",
            "MetricName": "FortinetCompleteOWASPTopTenRuleset"
        }
    ]
}

$ aws waf list-subscribed-rule-groups
{
    "RuleGroups": [
        {
            "RuleGroupId": "fecbf80a-be95-43f2-a891-972c722f32f6",
            "Name": "Fortinet Managed Rules for AWS WAF - Complete OWASP Top 10",
            "MetricName": "FortinetCompleteOWASPTopTenRuleset"
        }
    ]
}

New or Affected Resource(s)

  • aws_waf_subscribed_rule_group
  • aws_wafregional_subscribed_rule_group

Potential Terraform Configuration

data "aws_waf_subscribed_rule_group" "example" {
  name = ""
}

data "aws_wafregional_subscribed_rule_group" "example" {
  name = ""
}

References

@haidaraM haidaraM added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 16, 2020
@ghost ghost added the service/waf Issues and PRs that pertain to the waf service. label Mar 16, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 16, 2020
@DrFaust92
Copy link
Collaborator

addressed by #10563

@breathingdust breathingdust added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 22, 2021
@github-actions github-actions bot added this to the v4.25.0 milestone Aug 3, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This functionality has been released in v4.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/waf Issues and PRs that pertain to the waf service.
Projects
None yet
3 participants