Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_glue_catalog_table.ser_de_info.name is documented as optional, but fails if not specified #12519

Closed
lbenedetto opened this issue Mar 25, 2020 · 3 comments · Fixed by #12523
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service.
Milestone

Comments

@lbenedetto
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v0.12.24

  • provider.aws v2.54.0

Affected Resource(s)

  • aws_glue_catalog_table.ser_de_info.name

Issue

The name field of ser_de_info is documented as being optional, but if it is not specified, and error is given when attempting to apply

Error: Error updating Glue Catalog Table: InvalidParameter: 1 validation error(s) found.
- minimum field size of 1, UpdateTableInput.TableInput.StorageDescriptor.SerdeInfo.Name.

Looks like it's trying to set name to "" instead of null like it says it's going to do in the diff

~ ser_de_info {
    - name                  = "testName" -> null
      parameters            = {
          "serialization.format" = "1"
      }
      serialization_library = "org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe"
}

References

ser_de_info
name - (Optional) Name of the SerDe.
https://www.terraform.io/docs/providers/aws/r/glue_catalog_table.html#ser_de_info

@ghost ghost added the service/glue Issues and PRs that pertain to the glue service. label Mar 25, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 25, 2020
@drexler
Copy link
Contributor

drexler commented Mar 25, 2020

Yeah, there are some missing validation checks for this. Looking at the Go SDK -AWS Glue Reference, both the Name and SerializationLibrary properties require at least one character.

@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 29, 2020
@breathingdust breathingdust added this to the v3.12.0 milestone Oct 21, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants