Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/codebuild_report_group - add new resource #12573

Merged
merged 12 commits into from
Aug 28, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Mar 29, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12178

Release note for CHANGELOG:

resource_aws_codebuild_report_group - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeBuildReportGroup_'
--- PASS: TestAccAWSCodeBuildReportGroup_export_s3 (121.99s)
--- PASS: TestAccAWSCodeBuildReportGroup_tags (89.06s)
--- PASS: TestAccAWSCodeBuildReportGroup_disappears (28.05s)
--- PASS: TestAccAWSCodeBuildReportGroup_basic (37.50s)

@DrFaust92 DrFaust92 requested a review from a team March 29, 2020 16:41
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 29, 2020
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCodeBuildReportGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildReportGroup_ -timeout 120m
=== RUN   TestAccAWSCodeBuildReportGroup_basic
=== PAUSE TestAccAWSCodeBuildReportGroup_basic
=== RUN   TestAccAWSCodeBuildReportGroup_updated
=== PAUSE TestAccAWSCodeBuildReportGroup_updated
=== RUN   TestAccAWSCodeBuildReportGroup_disappears
=== PAUSE TestAccAWSCodeBuildReportGroup_disappears
=== CONT  TestAccAWSCodeBuildReportGroup_basic
=== CONT  TestAccAWSCodeBuildReportGroup_disappears
=== CONT  TestAccAWSCodeBuildReportGroup_updated
--- PASS: TestAccAWSCodeBuildReportGroup_disappears (61.10s)
--- PASS: TestAccAWSCodeBuildReportGroup_basic (65.39s)
--- PASS: TestAccAWSCodeBuildReportGroup_updated (92.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	92.073s

@rubytobi
Copy link

rubytobi commented May 21, 2020

@DrFaust92 awesome, thx for implementing this!
Just saw that AWS rolled out tagging for report groups. Do you think you could add support for this as well?
Maybe it's worth pinging some reviewers afterwards - almost two months since your implementation :)

@DrFaust92
Copy link
Collaborator Author

Hey @rubytobi, i can address this when #13459 is merged.

@DrFaust92 DrFaust92 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 22, 2020
@DrFaust92 DrFaust92 force-pushed the r/codebuild_report_groups branch 2 times, most recently from 0317df3 to 44996f1 Compare July 15, 2020 17:59
@DrFaust92 DrFaust92 force-pushed the r/codebuild_report_groups branch from 44996f1 to e627619 Compare August 28, 2020 10:38
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeBuildReportGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildReportGroup_ -timeout 120m
=== RUN   TestAccAWSCodeBuildReportGroup_basic
=== PAUSE TestAccAWSCodeBuildReportGroup_basic
=== RUN   TestAccAWSCodeBuildReportGroup_export_s3
=== PAUSE TestAccAWSCodeBuildReportGroup_export_s3
=== RUN   TestAccAWSCodeBuildReportGroup_tags
=== PAUSE TestAccAWSCodeBuildReportGroup_tags
=== RUN   TestAccAWSCodeBuildReportGroup_disappears
=== PAUSE TestAccAWSCodeBuildReportGroup_disappears
=== CONT  TestAccAWSCodeBuildReportGroup_basic
=== CONT  TestAccAWSCodeBuildReportGroup_disappears
=== CONT  TestAccAWSCodeBuildReportGroup_tags
=== CONT  TestAccAWSCodeBuildReportGroup_export_s3
=== CONT  TestAccAWSCodeBuildReportGroup_disappears
    resource_aws_codebuild_report_group_test.go:142: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeBuildReportGroup_disappears (17.93s)
--- PASS: TestAccAWSCodeBuildReportGroup_basic (24.08s)
--- PASS: TestAccAWSCodeBuildReportGroup_tags (47.91s)
--- PASS: TestAccAWSCodeBuildReportGroup_export_s3 (59.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.341s

@DrFaust92
Copy link
Collaborator Author

rebased

--- PASS: TestAccAWSCodeBuildReportGroup_export_s3 (121.99s)
--- PASS: TestAccAWSCodeBuildReportGroup_tags (89.06s)
--- PASS: TestAccAWSCodeBuildReportGroup_disappears (28.05s)
--- PASS: TestAccAWSCodeBuildReportGroup_basic (37.50s)

@bflad bflad self-assigned this Aug 28, 2020
@bflad bflad added this to the v3.5.0 milestone Aug 28, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCodeBuildReportGroup_disappears (12.89s)
--- PASS: TestAccAWSCodeBuildReportGroup_basic (17.09s)
--- PASS: TestAccAWSCodeBuildReportGroup_export_s3 (30.81s)
--- PASS: TestAccAWSCodeBuildReportGroup_tags (38.91s)

@bflad bflad merged commit fad2007 into hashicorp:master Aug 28, 2020
bflad added a commit that referenced this pull request Aug 28, 2020
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/codebuild Issues and PRs that pertain to the codebuild service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Reports with AWS CodeBuild
4 participants