Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement aws_db_cluster_snapshot Sweeper #12663

Closed
bflad opened this issue Apr 3, 2020 · 2 comments · Fixed by #13301
Closed

Implement aws_db_cluster_snapshot Sweeper #12663

bflad opened this issue Apr 3, 2020 · 2 comments · Fixed by #13301
Labels
service/rds Issues and PRs that pertain to the rds service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Apr 3, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The acceptance testing can leave lingering resources on failed runs (e.g. via coding issues during development or panics). These lingering resources can cause quota limits to be reached, extraneous money to be spent, or in some worst cases leave open security risks in the testing account.

We do not require sweeper implementation during initial resource implementation at this time, but this may change in the future when the process can be simplified and documented better.

e.g. after many years of daily (or more) testing runs

$ aws rds describe-db-cluster-snapshots | jq '.DBClusterSnapshots | length'
41

This resource sweeper should have dependencies on upstream resources, e.g.

  • aws_rds_cluster

New or Affected Resource(s)

  • aws_db_cluster_snapshot

Definition of Done

  • Sweeper implemented without errors
  • Testing account empty of this resource:
$ aws rds describe-db-cluster-snapshots | jq '.DBClusterSnapshots | length'
0
@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Apr 3, 2020
@ghost ghost added the service/rds Issues and PRs that pertain to the rds service. label Apr 3, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 3, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 3, 2020
@bflad bflad added this to the v2.63.0 milestone May 20, 2020
@ghost
Copy link

ghost commented May 22, 2020

This has been released in version 2.63.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jun 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/rds Issues and PRs that pertain to the rds service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant