Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags attribute to aws_iam_user data source. #13287

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

Omicron7
Copy link
Contributor

@Omicron7 Omicron7 commented May 12, 2020

This adds the tags attribute to the aws_iam_user data source. This was copied from the aws_iam_role data source and updated to work with user.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* data-source/aws_iam_user: Add `tags` attribute

Closes #13470

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDataSourceIAMUser_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSDataSourceIAMUser_ -timeout 120m
...
--- PASS: TestAccAWSDataSourceIAMUser_basic (14.90s)
--- PASS: TestAccAWSDataSourceIAMUser_tags (14.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.446s
...

@Omicron7 Omicron7 requested a review from a team May 12, 2020 17:40
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels May 12, 2020
@Omicron7
Copy link
Contributor Author

Omicron7 commented Jul 9, 2020

@bflad Any chance we can get this is an upcoming release? The API call used to fetch the user already includes the tags response, this is just exposing it on the data source.
Thanks.

@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 20, 2021
@anGie44
Copy link
Contributor

anGie44 commented Jan 20, 2021

Thank you for this PR @Omicron7 ! I'm going to push up some small changes to trigger the lint checks as the import line for example will cause an error and adjust the line that sets the non-primitive "tags" object as we need to check for possible errors.

@Omicron7 Omicron7 requested a review from a team as a code owner January 20, 2021 02:20
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jan 20, 2021
@anGie44 anGie44 force-pushed the add-tags-to-iam-user-datasource branch from c4dfaba to c1aa717 Compare January 20, 2021 02:36
@anGie44 anGie44 added this to the v3.25.0 milestone Jan 20, 2021
@Omicron7
Copy link
Contributor Author

@anGie44 Thanks for working on this.

@anGie44 anGie44 merged commit 72f5fe8 into hashicorp:master Jan 20, 2021
anGie44 added a commit that referenced this pull request Jan 20, 2021
@ghost
Copy link

ghost commented Jan 22, 2021

This has been released in version 3.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tags attribute to aws_iam_user data source
2 participants