r/api_gateway_rest_api_policy - add new resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #5834
Relates #5549
Relates #10986

Release note for CHANGELOG:

resource_aws_api_gateway_rest_api_policy: new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayRestApiPolicy_'
--- PASS: TestAccAWSAPIGatewayRestApiPolicy_basic (165.57s)
--- PASS: TestAccAWSAPIGatewayRestApiPolicy_disappears (68.53s)
--- PASS: TestAccAWSAPIGatewayRestApiPolicy_disappears_restApi (80.66s)

[ultrafez]

Thank you for raising this PR! I've been experiencing #5549, so I'm grateful for you taking the time to work on a fix.

Apparently there are conflicts on website/aws.erb, does this branch need rebasing before it can be reviewed/merged?

[DrFaust92]

Rebased and refactored

[slikk66]

how long does this usually take to merge an all green PR ?

[bflad]

Thanks, @DrFaust92 🚀

Output from acceptance testing (see other comment for failure details):

--- PASS: TestAccAWSAPIGatewayRestApiPolicy_disappears_restApi (16.41s)
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (45.41s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (74.27s)
--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (106.42s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (113.88s)
--- PASS: TestAccAWSAPIGatewayRestApiPolicy_disappears (141.26s)
--- PASS: TestAccAWSAPIGatewayRestApi_tags (168.51s)
--- FAIL: TestAccAWSAPIGatewayRestApi_policy (199.92s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (268.79s)
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (385.07s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (386.16s)
--- PASS: TestAccAWSAPIGatewayRestApiPolicy_basic (428.07s)

[bflad]

This update breaks the existing TestAccAWSAPIGatewayRestApi_policy test:

=== CONT  TestAccAWSAPIGatewayRestApi_policy
TestAccAWSAPIGatewayRestApi_policy: resource_aws_api_gateway_rest_api_test.go:446: Step 4/4 error: Check failed: Check 1/1 error: aws_api_gateway_rest_api.test: Attribute 'policy' expected "", got "{\"Version\":\"2012-10-17\",\"Statement\":[{\"Effect\":\"Deny\",\"Principal\":{\"AWS\":\"*\"},\"Action\":\"execute-api:Invoke\",\"Resource\":\"*\"}]}"
--- FAIL: TestAccAWSAPIGatewayRestApi_policy (199.92s)

Since the removal behavior is expected unless it is configured to an empty string (""), will update the test and document the behavior in the resource documentation on merge.

[slikk66]

how long does this usually take to merge an all green PR ?

apparently 76 days :p

[ghost]

This has been released in version 3.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!