Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_glue_security_configuration send empty kms_arn in DISABLED configs #13620

Closed
AndresCidoncha opened this issue Jun 4, 2020 · 2 comments · Fixed by #13618
Closed

aws_glue_security_configuration send empty kms_arn in DISABLED configs #13620

AndresCidoncha opened this issue Jun 4, 2020 · 2 comments · Fixed by #13618
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service.
Milestone

Comments

@AndresCidoncha
Copy link
Contributor

AndresCidoncha commented Jun 4, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

v0.12.26

Affected Resource(s)

  • aws_glue_security_configuration

Terraform Configuration Files

resource "aws_glue_security_configuration" "s3_encryption" {
  name = "xaldigital-test"

  encryption_configuration {
    cloudwatch_encryption {
      cloudwatch_encryption_mode = "DISABLED"
    }

    job_bookmarks_encryption {
      job_bookmarks_encryption_mode = "DISABLED"
    }

    s3_encryption {
      kms_key_arn        = aws_kms_key.key.arn
      s3_encryption_mode = "SSE-KMS"
    }
  }
}

Debug Output

https://gist.github.com/AndresCidoncha/70cac98df4d5fd5c5e0c5b91f92c9103

Panic Output

Expected Behavior

Terraform must omit the kms_arn fields in the API call, so the security_configuration should look like this:

"CloudWatchEncryption":{"CloudWatchEncryptionMode":"DISABLED"},
"JobBookmarksEncryption":{"JobBookmarksEncryptionMode":"DISABLED"}

image

Actual Behavior

Instead, empty values for kms_arn are sent in the API call, so AWS creates the security_config with empty values for key_arn:

"CloudWatchEncryption":{"CloudWatchEncryptionMode":"DISABLED","KmsKeyArn":""},"JobBookmarksEncryption":{"JobBookmarksEncryptionMode":"DISABLED","KmsKeyArn":""}

image

Running an ETL with this security_config causes this error:

image

Steps to Reproduce

  1. terraform apply

Important Factoids

References

#13618

@ghost ghost added the service/glue Issues and PRs that pertain to the glue service. label Jun 4, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 4, 2020
@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 29, 2020
@breathingdust breathingdust added this to the v3.12.0 milestone Oct 21, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants