r/resource_aws_ssm_patch_baseline - add support for ApproveUntilDate attribute

[drexler]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13816

Release note for CHANGELOG:

add support for ApproveUntilDate attribute in resource_aws_ssm_patch_baseline

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMPatchBaseline'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSSMPatchBaseline -timeout 120m
=== RUN   TestAccAWSSSMPatchBaseline_basic
=== PAUSE TestAccAWSSSMPatchBaseline_basic
=== RUN   TestAccAWSSSMPatchBaseline_tags
=== PAUSE TestAccAWSSSMPatchBaseline_tags
=== RUN   TestAccAWSSSMPatchBaseline_disappears
=== PAUSE TestAccAWSSSMPatchBaseline_disappears
=== RUN   TestAccAWSSSMPatchBaseline_OperatingSystem
=== PAUSE TestAccAWSSSMPatchBaseline_OperatingSystem
=== RUN   TestAccAWSSSMPatchBaseline_ApproveUntilDateParam
=== PAUSE TestAccAWSSSMPatchBaseline_ApproveUntilDateParam
=== RUN   TestAccAWSSSMPatchBaseline_InvalidConfiguration
=== PAUSE TestAccAWSSSMPatchBaseline_InvalidConfiguration
=== CONT  TestAccAWSSSMPatchBaseline_basic
=== CONT  TestAccAWSSSMPatchBaseline_InvalidConfiguration
=== CONT  TestAccAWSSSMPatchBaseline_disappears
=== CONT  TestAccAWSSSMPatchBaseline_OperatingSystem
=== CONT  TestAccAWSSSMPatchBaseline_tags
=== CONT  TestAccAWSSSMPatchBaseline_ApproveUntilDateParam
--- PASS: TestAccAWSSSMPatchBaseline_InvalidConfiguration (8.89s)
--- PASS: TestAccAWSSSMPatchBaseline_disappears (16.06s)
--- PASS: TestAccAWSSSMPatchBaseline_ApproveUntilDateParam (36.59s)
--- PASS: TestAccAWSSSMPatchBaseline_basic (36.68s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (36.90s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (49.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	49.899s

...

[dasbiswajit]

much needed.

[Mond18S]

need of the hour

[jjuliogallegos]

very needed please!

[bflad]

Thank you for submitting this, @drexler. After rebasing this, it is looking pretty good, just changing the error handling back as mentioned below. 👍

[bflad]

Thanks so much, @drexler 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSSSMPatchBaseline_disappears (14.78s)
--- PASS: TestAccAWSSSMPatchBaseline_ApprovedPatchesNonSec (20.17s)
--- PASS: TestAccAWSSSMPatchBaseline_RejectPatchesAction (20.74s)
--- PASS: TestAccAWSSSMPatchBaseline_Sources (30.82s)
--- PASS: TestAccAWSSSMPatchBaseline_basic (31.96s)
--- PASS: TestAccAWSSSMPatchBaseline_ApproveUntilDateParam (32.05s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (32.27s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (40.47s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSSSMPatchBaseline_disappears (18.20s)
--- PASS: TestAccAWSSSMPatchBaseline_RejectPatchesAction (25.20s)
--- PASS: TestAccAWSSSMPatchBaseline_ApprovedPatchesNonSec (25.66s)
--- PASS: TestAccAWSSSMPatchBaseline_basic (38.23s)
--- PASS: TestAccAWSSSMPatchBaseline_Sources (38.59s)
--- PASS: TestAccAWSSSMPatchBaseline_ApproveUntilDateParam (38.79s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (39.24s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (50.26s)

[ghost]

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!