Data source aws_vpcs should not fail if no VPCs are found

[ghost]

This issue was originally opened by @swetli as hashicorp/terraform#25141. It was migrated here as a result of the provider split. The original body of the issue is below.

---

Current Terraform Version

Terraform v0.12.25
+ provider.aws v2.64.0

Use-cases

I have a module which utilizes for_each to enable VPC flow logs on all VPCs found in a region, however if I run the module on account/region with empty VPC list the data source returns an error:
data "aws_vpcs" "all" {}

  on modules/vpc_logs/main.tf line 2, in data "aws_vpcs" "all":
   2: data "aws_vpcs" "all" {

Error: no matching VPC found

Proposal

data source "aws_vpcs" should return an empty list, like the aws cli:

aws--region=eu-west-1 ec2 describe-vpcs
{
    "Vpcs": []
}

References

[bcatubig]

This request makes sense in theory but in practice the aws_vpc data source is specifically used for returning data about a single vpc.

Looking at the code, it doesn't appear that this data source was designed to handle more than 1 vpc.

[swetli]

May be you should look at aws_vpcS then 😀

[bcatubig]

Gah! I totally missed that. I'm working on a PR to implement this.

[ewbankkit]

Relates:

• Feature Request: Allow data sources searching tags/filters to return empty results #8302

[anGie44]

Fixed with #22253

[github-actions]

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.