Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ses_event_destination - add arn + validation #13964

Merged
merged 7 commits into from
Feb 11, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624

Release note for CHANGELOG:

resource_aws_ses_event_destination: add arn attribute
resource_aws_ses_event_destination: plan time validation for `name`, `cloudwatch_destination.default_value`, `cloudwatch_destination.default_name`, `kinesis_destination.role_arn`, `kinesis_destination.stream_arn`,
`sns_destination.topic_arn`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSESEventDestination_'
--- PASS: TestAccAWSSESEventDestination_basic (179.55s)
--- PASS: TestAccAWSSESEventDestination_disappears (160.52s)

@DrFaust92 DrFaust92 requested a review from a team June 26, 2020 21:51
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ses Issues and PRs that pertain to the ses service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 26, 2020
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Jul 25, 2020
@DrFaust92 DrFaust92 force-pushed the r/ses_event_destination_arn branch from 46d3068 to 452a086 Compare July 25, 2020 13:13
@DrFaust92 DrFaust92 force-pushed the r/ses_event_destination_arn branch from 59fd266 to ccfcd0d Compare November 12, 2020 19:08
@DrFaust92 DrFaust92 requested a review from a team as a code owner November 12, 2020 19:08
Base automatically changed from master to main January 23, 2021 00:58
@bflad bflad self-assigned this Feb 11, 2021
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 11, 2021
@bflad
Copy link
Contributor

bflad commented Feb 11, 2021

Ready for rebase and changelog (can do myself later today if you're not available 👍 )

@DrFaust92
Copy link
Collaborator Author

On it

@DrFaust92 DrFaust92 force-pushed the r/ses_event_destination_arn branch from ccfcd0d to c9208cf Compare February 11, 2021 15:29
@DrFaust92 DrFaust92 force-pushed the r/ses_event_destination_arn branch from c9208cf to b3dfdf5 Compare February 11, 2021 15:30
.changelog/13964.txt Outdated Show resolved Hide resolved
.changelog/13964.txt Outdated Show resolved Hide resolved
website/docs/r/ses_event_destination.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, looks good to me, @DrFaust92 🚀

References:

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSSESEventDestination_disappears (85.94s)
--- PASS: TestAccAWSSESEventDestination_basic (98.02s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSSESEventDestination_disappears (75.67s)
--- PASS: TestAccAWSSESEventDestination_basic (78.60s)

@bflad bflad merged commit b41d553 into hashicorp:main Feb 11, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
@DrFaust92 DrFaust92 deleted the r/ses_event_destination_arn branch April 15, 2021 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/ses Issues and PRs that pertain to the ses service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants