Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS apigatewayv2 integrations - https endpoint (ServerNameToVerify) #14015

Closed
msirovy opened this issue Jul 1, 2020 · 2 comments
Closed

AWS apigatewayv2 integrations - https endpoint (ServerNameToVerify) #14015

msirovy opened this issue Jul 1, 2020 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service.

Comments

@msirovy
Copy link

msirovy commented Jul 1, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

apigatewayv2 integration is not able to configure https endpoint because there is no way how to define parameter ServerNameToVerify.

New or Affected Resource(s)

The aws api request should looks like this way

{
    "Items": [
        {
            "ConnectionType": "VPC_LINK",
            "IntegrationMethod": "ANY",
            "IntegrationType": "HTTP_PROXY",
            "IntegrationUri": "arn:aws:elasticloadbalancing:eu-central-1:XXXXXXXXX:listener/app/lb/d----------------4",
            "PayloadFormatVersion": "1.0",
            "TimeoutInMillis": 29000,


            "TlsConfig": {
                "ServerNameToVerify": "valid.domain.tld"
            }


        }
    ]
}

It allows me to use https lb etc.

Potential Terraform Configuration

resource "aws_apigatewayv2_integration" "my_api" {
    api_id                          = aws_apigatewayv2_api.api.id
    connection_id                   = aws_apigatewayv2_vpc_link.vpc_link.id
    connection_type                 = "VPC_LINK"
    integration_method              = "ANY"
    integration_type                = "HTTP_PROXY"
    integration_uri                 = aws_lb_listener.https.arn        
    passthrough_behavior            = "WHEN_NO_MATCH"
    payload_format_version          = "1.0"


    HTTPS_HOSTNAME.           = "valid.domain.tld"


    request_templates               = {}
    timeout_milliseconds            = 29000
}

References

@msirovy msirovy added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 1, 2020
@ghost ghost added the service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. label Jul 1, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 1, 2020
@ewbankkit
Copy link
Contributor

@msirovy Thanks for raising this issue.
It has already been noticed in #12971 (missing tls_config for aws_apigatewayv2_integration) and is being addressed in #13013. I will close this issue as a duplicate.
Please add any additional information to the linked issue.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 1, 2020
@ghost
Copy link

ghost commented Jul 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service.
Projects
None yet
Development

No branches or pull requests

2 participants