Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/api_gateway_usage_plan - change api_stages to set to fix ordering change #14345

Merged
merged 9 commits into from
Oct 29, 2020
Merged

r/api_gateway_usage_plan - change api_stages to set to fix ordering change #14345

merged 9 commits into from
Oct 29, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1675

Release note for CHANGELOG:

resource_aws_api_gateway_usage_plan - change `api_stages` to type set

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayUsagePlan_'
--- PASS: TestAccAWSAPIGatewayUsagePlan_tags (129.57s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_description (195.11s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_productCode (185.23s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_throttling (192.53s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_throttlingInitialRateLimit (94.42s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_quota (174.57s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_apiStages (231.82s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_apiStages_multiple (77.07s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_disappears (63.35s)

@DrFaust92 DrFaust92 requested a review from a team July 25, 2020 10:25
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 25, 2020
@DrFaust92 DrFaust92 force-pushed the r/api_gateway_usage_plan_multi_stage branch from dab0632 to 60efa47 Compare August 29, 2020 19:35
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Aug 29, 2020
@DrFaust92 DrFaust92 force-pushed the r/api_gateway_usage_plan_multi_stage branch from fcbb715 to f5af58b Compare September 20, 2020 10:50
@DrFaust92
change api_stages to set
4da1231 
extract lists/set expansion to functions
move usage plan flattners to usage plan file
refactor tests
@DrFaust92
extra checks for basic test
cc6b5e0
@DrFaust92
tf12 syntax
42c97cf
@DrFaust92
update test
2f393cc
@DrFaust92
use enum slice
0f01600
@DrFaust92 DrFaust92 force-pushed the r/api_gateway_usage_plan_multi_stage branch from cc6ed42 to 0f01600 Compare September 21, 2020 20:55
@gdavison gdavison self-assigned this Oct 8, 2020
gdavison
gdavison approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSAPIGatewayUsagePlan_basic (49.90s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_throttling (83.80s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_throttlingInitialRateLimit (117.78s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_tags (117.77s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_quota (174.30s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_disappears (209.12s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_apiStages_multiple (252.00s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_description (311.16s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_productCode (348.87s)
--- PASS: TestAccAWSAPIGatewayUsagePlan_apiStages (409.52s)

@gdavison
Update resource_aws_api_gateway_usage_plan.go
23eaafb 
`validateApiGatewayUsagePlanQuotaSettings()` returns a slice of errors
@gdavison gdavison added this to the v3.13.0 milestone Oct 22, 2020
@gdavison gdavison merged commit 31cbed4 into hashicorp:master Oct 29, 2020
gdavison added a commit that referenced this pull request Oct 29, 2020
@gdavison
Update CHANGELOG for #14345
1647291
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2020
@DrFaust92 DrFaust92 deleted the r/api_gateway_usage_plan_multi_stage branch April 15, 2021 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.

Order not retained for api_stages in aws_api_gateway_usage_plan
2 participants
@DrFaust92 @gdavison