Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow_major_version_upgrade is missing from aws_dms_replication_instance #14438

Closed
eoliphan opened this issue Jul 31, 2020 · 4 comments · Fixed by #14550
Closed

allow_major_version_upgrade is missing from aws_dms_replication_instance #14438

eoliphan opened this issue Jul 31, 2020 · 4 comments · Fixed by #14550
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Milestone

Comments

@eoliphan
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The AllowMajorVersionUpgrade flag is necessary to perform major updates to the aws_dms_replication_instance type

New or Affected Resource(s)

aws_dms_replication_instance

Potential Terraform Configuration

resource "aws_dms_replication_instance" "default" {
  allocated_storage            = var.allocated_storage
  apply_immediately            = true
  auto_minor_version_upgrade   = true
  engine_version               = var.engine_version
  allow_major_version_upgrade = true

References

@eoliphan eoliphan added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 31, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 31, 2020
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 1, 2020
@bflad
Copy link
Contributor

bflad commented Aug 7, 2020

Adding this functionality would also allow fixing the currently failing test:

=== CONT  TestAccAWSDmsReplicationInstance_EngineVersion
TestAccAWSDmsReplicationInstance_EngineVersion: testing.go:684: Step 1 error: errors during apply:
Error: error modifying DMS Replication Instance (tf-acc-test-1816079488213827146): InvalidParameterCombinationException: The AllowMajorVersionUpgrade flag must be present when upgrading to a new major version.

@bflad
Copy link
Contributor

bflad commented Aug 14, 2020

Support for this new argument has been merged and will release with version 3.3.0 of the Terraform AWS Provider, next week. Thanks to @shuheiktgw for the implementation. 👍

@ghost
Copy link

ghost commented Aug 20, 2020

This has been released in version 3.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
3 participants