Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource/lb_listener: Add alpn policy argument #14462

Merged
merged 15 commits into from
Apr 5, 2021

Conversation

knorby
Copy link
Contributor

@knorby knorby commented Aug 4, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13532

Release note for CHANGELOG:

resource/lb_listener: Adds `alpn_policy` argument

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@knorby knorby requested a review from a team August 4, 2020 03:00
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/elbv2 Issues and PRs that pertain to the elbv2 service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 4, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 1, 2020
@knorby
Copy link
Contributor Author

knorby commented Oct 30, 2020

I'm sorry, I don't have a good test environment for acceptance tests. I'm going to remove the WIP label from this PR

@knorby knorby changed the title [WIP] Resource/lb_listener: Add alpn policy argument Resource/lb_listener: Add alpn policy argument Oct 30, 2020
@jkroepke
Copy link

Can it merge?

@matthiaslee
Copy link

What does this PR need to be merged?

@knorby
Copy link
Contributor Author

knorby commented Jan 7, 2021

Nothing blocking from me

@moemoeq
Copy link

moemoeq commented Jan 19, 2021

when it will be merge? i got pain because of this needs to control on code .

Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@Ushanta-Mooloo
Copy link

Hi, when will this change be available? Right, the only solutions is to manually update the ALPN.

@YakDriver YakDriver self-assigned this Apr 2, 2021
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Apr 2, 2021
@YakDriver
Copy link
Member

This is waiting on #14245

@tmccombs
Copy link
Contributor

tmccombs commented Apr 3, 2021

looks like #14245 was merged.

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Apr 5, 2021
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Apr 5, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

Acceptance tests on commercial (us-west-2):

--- PASS: TestAccDataSourceAWSLBListener_DefaultAction_Forward (167.58s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (171.88s)
--- PASS: TestAccDataSourceAWSLBListener_BackwardsCompatibility (171.76s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (176.53s)
--- PASS: TestAccAWSLBListener_BackwardsCompatibility (177.58s)
--- PASS: TestAccAWSLBListener_fixedResponse (182.51s)
--- PASS: TestAccAWSLBListener_basic (186.67s)
--- PASS: TestAccAWSLBListener_https (192.28s)
--- PASS: TestAccAWSLBListener_oidc (192.83s)
--- PASS: TestAccDataSourceAWSLBListener_basic (192.97s)
--- PASS: TestAccDataSourceAWSLBListener_https (205.82s)
--- PASS: TestAccAWSLBListener_forwardWeighted (229.55s)
--- PASS: TestAccAWSLBListener_redirect (231.22s)
--- PASS: TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer (238.53s)
--- PASS: TestAccAWSLBListener_cognito (239.97s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (334.97s)
--- PASS: TestAccAWSLBListener_basicUdp (376.08s)

Acceptance tests on GovCloud:

--- SKIP: TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer (32.38s)
--- SKIP: TestAccAWSLBListener_cognito (161.19s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (163.59s)
--- PASS: TestAccDataSourceAWSLBListener_DefaultAction_Forward (177.78s)
--- PASS: TestAccDataSourceAWSLBListener_BackwardsCompatibility (179.90s)
--- PASS: TestAccDataSourceAWSLBListener_https (182.10s)
--- PASS: TestAccDataSourceAWSLBListener_basic (185.32s)
--- PASS: TestAccAWSLBListener_redirect (186.09s)
--- PASS: TestAccAWSLBListener_BackwardsCompatibility (189.21s)
--- PASS: TestAccAWSLBListener_oidc (191.45s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (193.96s)
--- PASS: TestAccAWSLBListener_fixedResponse (207.43s)
--- PASS: TestAccAWSLBListener_https (212.31s)
--- PASS: TestAccAWSLBListener_basic (221.69s)
--- PASS: TestAccAWSLBListener_forwardWeighted (247.68s)
--- PASS: TestAccAWSLBListener_basicUdp (345.12s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (398.14s)

@YakDriver YakDriver merged commit c891864 into hashicorp:main Apr 5, 2021
@YakDriver YakDriver added this to the v3.36.0 milestone Apr 5, 2021
@knorby knorby deleted the issue-13532-alpn-policy branch April 5, 2021 20:01
@ghost
Copy link

ghost commented Apr 9, 2021

This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network Load Balancer now supports TLS ALPN policies
8 participants