-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource/lb_listener: Add alpn policy argument #14462
Conversation
I'm sorry, I don't have a good test environment for acceptance tests. I'm going to remove the WIP label from this PR |
Can it merge? |
What does this PR need to be merged? |
Nothing blocking from me |
when it will be merge? i got pain because of this needs to control on code . |
Hi, when will this change be available? Right, the only solutions is to manually update the ALPN. |
ff6cf74
to
204fcfd
Compare
This is waiting on #14245 |
looks like #14245 was merged. |
7a8f6b1
to
38bd855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
Acceptance tests on commercial (us-west-2
):
--- PASS: TestAccDataSourceAWSLBListener_DefaultAction_Forward (167.58s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (171.88s)
--- PASS: TestAccDataSourceAWSLBListener_BackwardsCompatibility (171.76s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (176.53s)
--- PASS: TestAccAWSLBListener_BackwardsCompatibility (177.58s)
--- PASS: TestAccAWSLBListener_fixedResponse (182.51s)
--- PASS: TestAccAWSLBListener_basic (186.67s)
--- PASS: TestAccAWSLBListener_https (192.28s)
--- PASS: TestAccAWSLBListener_oidc (192.83s)
--- PASS: TestAccDataSourceAWSLBListener_basic (192.97s)
--- PASS: TestAccDataSourceAWSLBListener_https (205.82s)
--- PASS: TestAccAWSLBListener_forwardWeighted (229.55s)
--- PASS: TestAccAWSLBListener_redirect (231.22s)
--- PASS: TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer (238.53s)
--- PASS: TestAccAWSLBListener_cognito (239.97s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (334.97s)
--- PASS: TestAccAWSLBListener_basicUdp (376.08s)
Acceptance tests on GovCloud:
--- SKIP: TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer (32.38s)
--- SKIP: TestAccAWSLBListener_cognito (161.19s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (163.59s)
--- PASS: TestAccDataSourceAWSLBListener_DefaultAction_Forward (177.78s)
--- PASS: TestAccDataSourceAWSLBListener_BackwardsCompatibility (179.90s)
--- PASS: TestAccDataSourceAWSLBListener_https (182.10s)
--- PASS: TestAccDataSourceAWSLBListener_basic (185.32s)
--- PASS: TestAccAWSLBListener_redirect (186.09s)
--- PASS: TestAccAWSLBListener_BackwardsCompatibility (189.21s)
--- PASS: TestAccAWSLBListener_oidc (191.45s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (193.96s)
--- PASS: TestAccAWSLBListener_fixedResponse (207.43s)
--- PASS: TestAccAWSLBListener_https (212.31s)
--- PASS: TestAccAWSLBListener_basic (221.69s)
--- PASS: TestAccAWSLBListener_forwardWeighted (247.68s)
--- PASS: TestAccAWSLBListener_basicUdp (345.12s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (398.14s)
This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #13532
Release note for CHANGELOG:
Output from acceptance testing: