Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http_endpoint_configuration to r/aws_kinesis_firehose_delivery_stream #14469

Closed
radamisa opened this issue Aug 4, 2020 · 6 comments · Fixed by #15356
Closed

Add http_endpoint_configuration to r/aws_kinesis_firehose_delivery_stream #14469

radamisa opened this issue Aug 4, 2020 · 6 comments · Fixed by #15356
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Milestone

Comments

@radamisa
Copy link

radamisa commented Aug 4, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Amazon Kinesis Data Firehose HTTP endpoint delivery was introduced to Firehose a week ago. This is a request to add http_endpoint_configuration to aws_kinesis_firehose_delivery_stream.

New or Affected Resource(s)

r/aws_kinesis_firehose_delivery_stream

Potential Terraform Configuration

resource "aws_kinesis_firehose_delivery_stream" "test_stream" {
  name        = "terraform-kinesis-firehose-test-stream"
  destination = "http_endpoint"

  s3_configuration { // Similar to implementation in splunk_configuration, this maps to HttpEndpointDestinationConfiguration.S3Configuration
    role_arn           = aws_iam_role.firehose.arn
    bucket_arn         = aws_s3_bucket.bucket.arn
    buffer_size        = 10
    buffer_interval    = 400
    compression_format = "GZIP"
  }

  http_endpoint_configuration {
    url        = "https://api.example.com:443"
    name       = "MyHTTPEndpoint"
    access_key = "my-key"
    buffering_hints {
      size_in_mb = 5
      interval_in_seconds = 300
    }
   // cloudwatch_logging_options is CloudWatchLoggingOptions as used in s3_configuration
   // processing_configuration is ProcessingConfiguration as used in extended_s3_configuration
   role_arn       = "arn:my_role"
   s3_backup_mode = "FailedDataOnly"
  }
}

References

@radamisa radamisa added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 4, 2020
@ghost ghost added the service/firehose Issues and PRs that pertain to the firehose service. label Aug 4, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 4, 2020
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 4, 2020
@ewbankkit
Copy link
Contributor

@ZsoltPath
Copy link
Contributor

I'd work on it for a few days if nobody else.
I hope I can open a PR then.

@ZsoltPath
Copy link
Contributor

Please vote on the PR linked above to sort his out!

@bflad bflad added this to the v3.15.0 milestone Nov 6, 2020
@bflad bflad self-assigned this Nov 6, 2020
@bflad
Copy link
Contributor

bflad commented Nov 6, 2020

Initial support for this functionality has been merged and will release with version 3.15.0 of the Terraform AWS Provider, likely later next week. Thanks to @ZsoltPath for the implementation. 👍

@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants