Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/resource/aws_ecs_service: TestAccAWSEcsService_withMultipleTargetGroups Consistently Failing #14509

Closed
bflad opened this issue Aug 7, 2020 · 2 comments · Fixed by #14586
Labels
good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/ecs Issues and PRs that pertain to the ecs service. service/elbv2 Issues and PRs that pertain to the elbv2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Aug 7, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently there is a consistently failing test:

=== CONT  TestAccAWSEcsService_withMultipleTargetGroups
TestAccAWSEcsService_withMultipleTargetGroups: testing.go:684: Step 0 error: config is invalid: 2 problems:
- Unsupported argument: An argument named "field" is not expected here.
- Unsupported argument: An argument named "values" is not expected here.

These two arguments were deprecated with replacements awhile ago but this test configuration was not updated. With the recent removal of the arguments, this test is now failing. Updating the test configuration to use the new configuration blocks should fix the test.

New or Affected Resource(s)

  • aws_ecs_service

Definition of Done

  • TestAccAWSEcsService_withMultipleTargetGroups testing passes

References

@bflad bflad added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. service/elbv2 Issues and PRs that pertain to the elbv2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Aug 7, 2020
@bflad bflad added this to the Roadmap milestone Aug 7, 2020
@bflad bflad modified the milestones: Roadmap, v3.2.0 Aug 12, 2020
@ghost
Copy link

ghost commented Aug 14, 2020

This has been released in version 3.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/ecs Issues and PRs that pertain to the ecs service. service/elbv2 Issues and PRs that pertain to the elbv2 service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant