Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds encryption configuration to ECR repository resource and data source #14520

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Aug 7, 2020

Adds encryption_configuration attribute to aws_ecr_repository resource and data source.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14414

Release note for CHANGELOG:

* data-source/aws_ecr_repository: Add `encryption_configuration` attribute
* resource/aws_ecr_repository: Add `encryption_configuration` attribute

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcrRepository_\|TestAccAWSEcrRepositoryDataSource_'

--- PASS: TestAccAWSEcrRepositoryDataSource_nonExistent (3.68s)
--- PASS: TestAccAWSEcrRepository_immutability (13.86s)
--- PASS: TestAccAWSEcrRepository_basic (13.95s)
--- PASS: TestAccAWSEcrRepositoryDataSource_basic (14.88s)
--- PASS: TestAccAWSEcrRepositoryDataSource_encryption (17.83s)
--- PASS: TestAccAWSEcrRepository_tags (20.06s)
--- PASS: TestAccAWSEcrRepository_encryption_kms (25.54s)
--- PASS: TestAccAWSEcrRepository_encryption_aes256 (25.80s)
--- PASS: TestAccAWSEcrRepository_image_scanning_configuration (31.62s)

@gdavison gdavison requested a review from a team August 7, 2020 22:03
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/ecr Issues and PRs that pertain to the ecr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Aug 7, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, otherwise LGTM 🚀

aws/resource_aws_ecr_repository.go Outdated Show resolved Hide resolved
@bflad bflad added this to the v3.1.0 milestone Aug 7, 2020
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 7, 2020
Co-authored-by: Brian Flad <bflad417@gmail.com>
@gdavison gdavison merged commit f9b9171 into master Aug 7, 2020
@gdavison gdavison deleted the f-ecr-encryption branch August 7, 2020 22:57
gdavison added a commit that referenced this pull request Aug 7, 2020
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ECR server-side encryption
2 participants