Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SES Email feedback forwarding configuration #14622

Closed
faisalp4p opened this issue Aug 13, 2020 · 8 comments · Fixed by #27433
Closed

Support for SES Email feedback forwarding configuration #14622

faisalp4p opened this issue Aug 13, 2020 · 8 comments · Fixed by #27433
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/ses Issues and PRs that pertain to the ses service.
Milestone

Comments

@faisalp4p
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

There is a configuration about Email feedback forwarding for SES. Currently it is not supported in any of the SES resources. people have to manually do it from the aws console.
ses_notif_config

There is a challenge to decide how we can support this configuration in TF. I can think of two options:

  1. Make a boolean parameter in aws_ses_domain_identity and aws_ses_email_identity. Adding a parameter to identity resource itself for notification configuration will be confusing to the users.
  2. Create a dedicated resource called aws_ses_identity_feedback_forwarding_enabled. Having a dedicated resource for a simple configuration might be an overkill.

Given both solutions are not perfect I would vote for 2 as it will not touch any existing resources.

I wanted to get some feedbacks on this. Thanks!

@faisalp4p faisalp4p added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 13, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 13, 2020
@ewbankkit ewbankkit added the service/ses Issues and PRs that pertain to the ses service. label Aug 13, 2020
@k3np
Copy link

k3np commented Aug 28, 2020

Duplicate of #4182

@djravine
Copy link

djravine commented Oct 13, 2020

Vote for option 2 - Create a dedicated resource called aws_ses_identity_feedback_forwarding_enabled

As with the existing resource aws_ses_identity_notification_topic you need to create the aws_ses_domain_identity first then reference it in the new resource. This would match the existing workflow/process.

# SES - Email Indentity
resource "aws_ses_email_identity" "ses" {
  email = var.ses_email_identity
}

# SES - Identity Notification - Bounce
resource "aws_ses_identity_notification_topic" "bounce" {
  topic_arn                = aws_sns_topic.events.arn
  notification_type        = "Bounce"
  identity                 = aws_ses_domain_identity.ses.domain
  include_original_headers = true
  depends_on = [aws_sns_topic.events]
}

# SES - Email Feedback Forwarding
resource "aws_ses_identity_feedback_forwarding_enabled" "ses" {
  identity                 = aws_ses_domain_identity.ses.domain
  enabled                  = false
}

@yuonoda
Copy link
Contributor

yuonoda commented Dec 23, 2020

I'm facing this issue now.
Not to send auto-reply to FROM address, I need to turn off feedback forwarding manually.

Suggestion by @djravine really make sense for me.

@yuonoda
Copy link
Contributor

yuonoda commented Dec 23, 2020

I opened the draft pull request for this issue.
Because this is my first PR for this repo, I'm welcome for everyone's help.
#16891

@anGie44 anGie44 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 28, 2021
@tmegow
Copy link

tmegow commented Aug 24, 2021

What's the status on this new resource? I need to disable feedback forwarding.

@rjhornsby
Copy link

+1. Importing our SES into Terraform, but this specific setting does not seem to be available anywhere in the TF provider? From the AWS console UI, it looks like this would belong to aws_ses_identity_notification_topic - but this UI choice might just be cosmetic.

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This functionality has been released in v4.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/ses Issues and PRs that pertain to the ses service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants