Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for aws_eks_node_group - launch template and custom AMI #14737

Closed
LozanoMatheus opened this issue Aug 19, 2020 · 2 comments
Closed

Updates for aws_eks_node_group - launch template and custom AMI #14737

LozanoMatheus opened this issue Aug 19, 2020 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. service/eks Issues and PRs that pertain to the eks service.

Comments

@LozanoMatheus
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Recently, AWS announced the support for launch template and custom AMI via EKS node Group.

New or Affected Resource(s)

  • aws_eks_node_group

Potential Terraform Configuration

resource "aws_launch_template" "example" {
  name = var.lc_name
  ...
}

resource "aws_eks_node_group" "example" {
  cluster_name    = aws_eks_cluster.example.name
  node_group_name = "example"
  node_role_arn   = aws_iam_role.example.arn
  subnet_ids      = aws_subnet.example[*].id

  launch_template {
    name    = aws_launch_template.example.name ## or var.lc_name
    version = aws_launch_template.example.latest_version
    id      = aws_launch_template.example.id
  }

  ami_type = "AL2_x86_64"

  scaling_config {
    desired_size = 1
    max_size     = 1
    min_size     = 1
  }
}

References

@LozanoMatheus LozanoMatheus added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 19, 2020
@ghost ghost added service/ec2 Issues and PRs that pertain to the ec2 service. service/eks Issues and PRs that pertain to the eks service. labels Aug 19, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 19, 2020
@bflad
Copy link
Contributor

bflad commented Aug 19, 2020

Hi @LozanoMatheus 👋 Thank you for submitting this feature request. This is covered by the previous #14702, so to consolidate efforts and discussions, I'm going to close this issue in preference of the existing one. Please 👍 upvote and subscribe there for further updates.

@bflad bflad closed this as completed Aug 19, 2020
@ghost
Copy link

ghost commented Sep 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 18, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Development

No branches or pull requests

3 participants