r/aws_lambda_event_source_mapping: Add MSK as an event source

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14658.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_kinesis_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaEventSourceMapping_kinesis_basic -timeout 120m
=== RUN   TestAccAWSLambdaEventSourceMapping_kinesis_basic
=== PAUSE TestAccAWSLambdaEventSourceMapping_kinesis_basic
=== CONT  TestAccAWSLambdaEventSourceMapping_kinesis_basic
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (74.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	74.492s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_MSK'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaEventSourceMapping_MSK -timeout 120m
=== RUN   TestAccAWSLambdaEventSourceMapping_MSK
=== PAUSE TestAccAWSLambdaEventSourceMapping_MSK
=== CONT  TestAccAWSLambdaEventSourceMapping_MSK
--- PASS: TestAccAWSLambdaEventSourceMapping_MSK (1678.87s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1678.910s

[DrFaust92]

Minor nits

[DrFaust92]

LGTM

--- PASS: TestAccAWSLambdaEventSourceMapping_MSK (1498.70s)

[migueldomingosaccenture]

Last comment 21 days ago. Can you review and approve this as we need this functionality too? Thanks

[stlimtat]

I need this function.

[yinchuandong]

I need this function

[feifanz]

I need this function

[yinchuandong]

@ewbankkit Hi mate, can you pls solve the conflicts? I am waiting for this feature for a long time. Can you pls push to merge it? Thanks!

[ewbankkit]

Rebased and resolved merge conflicts.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_MSK'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaEventSourceMapping_MSK -timeout 120m
=== RUN   TestAccAWSLambdaEventSourceMapping_MSK
=== PAUSE TestAccAWSLambdaEventSourceMapping_MSK
=== CONT  TestAccAWSLambdaEventSourceMapping_MSK
--- PASS: TestAccAWSLambdaEventSourceMapping_MSK (2235.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2235.483s

[AlexanderSchiff]

When will this be merged and released? Definitely need this

[bflad]

Looks good, thanks @ewbankkit 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName (55.29s)
--- FAIL: TestAccAWSLambdaEventSourceMapping_sqs_basic (64.70s) # https://github.com/hashicorp/terraform-provider-aws/pull/14765
--- PASS: TestAccAWSLambdaEventSourceMapping_SQSBatchWindow (77.70s)
--- PASS: TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp (83.78s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRecordAgeInSeconds (106.53s)
--- PASS: TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected (107.34s)
--- PASS: TestAccAWSLambdaEventSourceMapping_BisectBatch (107.85s)
--- PASS: TestAccAWSLambdaEventSourceMapping_KinesisDestinationConfig (108.87s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (109.37s)
--- PASS: TestAccAWSLambdaEventSourceMapping_disappears (112.05s)
--- PASS: TestAccAWSLambdaEventSourceMapping_KinesisBatchWindow (115.26s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttempts (116.99s)
--- PASS: TestAccAWSLambdaEventSourceMapping_ParallelizationFactor (117.33s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (118.04s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero (120.57s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MSK (1684.38s)

[ghost]

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!