r/glue_job - add non_overridable_arguments argument

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13117
Relates #13826

Release note for CHANGELOG:

resource_aws_glue_job - add `non_overridable_arguments` argument

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSGlueJob_basic (98.84s)
--- PASS: TestAccAWSGlueJob_nonOverridableArguments (116.92s)
--- PASS: TestAccAWSGlueJob_disappears (84.33s)

[DrFaust92]

Thanks, fixed according to comments:

--- PASS: TestAccAWSGlueJob_basic (88.25s)
--- PASS: TestAccAWSGlueJob_Command (124.58s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (108.23s)
--- PASS: TestAccAWSGlueJob_nonOverridableArguments (115.87s)
--- PASS: TestAccAWSGlueJob_GlueVersion (121.48s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (117.39s)
--- PASS: TestAccAWSGlueJob_MaxRetries (109.53s)
--- PASS: TestAccAWSGlueJob_Tags (153.29s)
--- PASS: TestAccAWSGlueJob_Timeout (162.15s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (208.34s)
--- PASS: TestAccAWSGlueJob_PythonShell (201.85s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (114.21s)
--- PASS: TestAccAWSGlueJob_disappears (55.87s)

[ewbankkit]

LGTM.

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueJob_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueJob_ -timeout 120m
=== RUN   TestAccAWSGlueJob_basic
=== PAUSE TestAccAWSGlueJob_basic
=== RUN   TestAccAWSGlueJob_Command
=== PAUSE TestAccAWSGlueJob_Command
=== RUN   TestAccAWSGlueJob_DefaultArguments
=== PAUSE TestAccAWSGlueJob_DefaultArguments
=== RUN   TestAccAWSGlueJob_nonOverridableArguments
=== PAUSE TestAccAWSGlueJob_nonOverridableArguments
=== RUN   TestAccAWSGlueJob_Description
=== PAUSE TestAccAWSGlueJob_Description
=== RUN   TestAccAWSGlueJob_GlueVersion
=== PAUSE TestAccAWSGlueJob_GlueVersion
=== RUN   TestAccAWSGlueJob_ExecutionProperty
=== PAUSE TestAccAWSGlueJob_ExecutionProperty
=== RUN   TestAccAWSGlueJob_MaxRetries
=== PAUSE TestAccAWSGlueJob_MaxRetries
=== RUN   TestAccAWSGlueJob_NotificationProperty
=== PAUSE TestAccAWSGlueJob_NotificationProperty
=== RUN   TestAccAWSGlueJob_Tags
=== PAUSE TestAccAWSGlueJob_Tags
=== RUN   TestAccAWSGlueJob_Timeout
=== PAUSE TestAccAWSGlueJob_Timeout
=== RUN   TestAccAWSGlueJob_SecurityConfiguration
=== PAUSE TestAccAWSGlueJob_SecurityConfiguration
=== RUN   TestAccAWSGlueJob_WorkerType
=== PAUSE TestAccAWSGlueJob_WorkerType
=== RUN   TestAccAWSGlueJob_PythonShell
=== PAUSE TestAccAWSGlueJob_PythonShell
=== RUN   TestAccAWSGlueJob_MaxCapacity
=== PAUSE TestAccAWSGlueJob_MaxCapacity
=== RUN   TestAccAWSGlueJob_disappears
=== PAUSE TestAccAWSGlueJob_disappears
=== CONT  TestAccAWSGlueJob_basic
=== CONT  TestAccAWSGlueJob_Tags
=== CONT  TestAccAWSGlueJob_disappears
=== CONT  TestAccAWSGlueJob_NotificationProperty
=== CONT  TestAccAWSGlueJob_MaxCapacity
=== CONT  TestAccAWSGlueJob_MaxRetries
=== CONT  TestAccAWSGlueJob_PythonShell
=== CONT  TestAccAWSGlueJob_ExecutionProperty
=== CONT  TestAccAWSGlueJob_WorkerType
=== CONT  TestAccAWSGlueJob_GlueVersion
=== CONT  TestAccAWSGlueJob_Description
=== CONT  TestAccAWSGlueJob_SecurityConfiguration
=== CONT  TestAccAWSGlueJob_Timeout
=== CONT  TestAccAWSGlueJob_nonOverridableArguments
=== CONT  TestAccAWSGlueJob_DefaultArguments
=== CONT  TestAccAWSGlueJob_Command
=== CONT  TestAccAWSGlueJob_disappears
    resource_aws_glue_job_test.go:644: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlueJob_disappears (74.40s)
--- PASS: TestAccAWSGlueJob_basic (84.07s)
--- PASS: TestAccAWSGlueJob_Description (138.57s)
--- PASS: TestAccAWSGlueJob_GlueVersion (139.25s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (139.51s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (139.73s)
--- PASS: TestAccAWSGlueJob_nonOverridableArguments (139.95s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (140.00s)
--- PASS: TestAccAWSGlueJob_Command (140.07s)
--- PASS: TestAccAWSGlueJob_Timeout (140.11s)
--- PASS: TestAccAWSGlueJob_NotificationProperty (140.45s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (140.65s)
--- PASS: TestAccAWSGlueJob_MaxRetries (142.35s)
--- PASS: TestAccAWSGlueJob_WorkerType (156.78s)
--- PASS: TestAccAWSGlueJob_PythonShell (157.37s)
--- PASS: TestAccAWSGlueJob_Tags (157.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	157.631s

[breathingdust]

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueJob_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueJob_ -timeout 120m
=== RUN   TestAccAWSGlueJob_basic
=== PAUSE TestAccAWSGlueJob_basic
=== RUN   TestAccAWSGlueJob_Command
=== PAUSE TestAccAWSGlueJob_Command
=== RUN   TestAccAWSGlueJob_DefaultArguments
=== PAUSE TestAccAWSGlueJob_DefaultArguments
=== RUN   TestAccAWSGlueJob_nonOverridableArguments
=== PAUSE TestAccAWSGlueJob_nonOverridableArguments
=== RUN   TestAccAWSGlueJob_Description
=== PAUSE TestAccAWSGlueJob_Description
=== RUN   TestAccAWSGlueJob_GlueVersion
=== PAUSE TestAccAWSGlueJob_GlueVersion
=== RUN   TestAccAWSGlueJob_ExecutionProperty
=== PAUSE TestAccAWSGlueJob_ExecutionProperty
=== RUN   TestAccAWSGlueJob_MaxRetries
=== PAUSE TestAccAWSGlueJob_MaxRetries
=== RUN   TestAccAWSGlueJob_NotificationProperty
=== PAUSE TestAccAWSGlueJob_NotificationProperty
=== RUN   TestAccAWSGlueJob_Tags
=== PAUSE TestAccAWSGlueJob_Tags
=== RUN   TestAccAWSGlueJob_Timeout
=== PAUSE TestAccAWSGlueJob_Timeout
=== RUN   TestAccAWSGlueJob_SecurityConfiguration
=== PAUSE TestAccAWSGlueJob_SecurityConfiguration
=== RUN   TestAccAWSGlueJob_WorkerType
=== PAUSE TestAccAWSGlueJob_WorkerType
=== RUN   TestAccAWSGlueJob_PythonShell
=== PAUSE TestAccAWSGlueJob_PythonShell
=== RUN   TestAccAWSGlueJob_MaxCapacity
=== PAUSE TestAccAWSGlueJob_MaxCapacity
=== RUN   TestAccAWSGlueJob_disappears
=== PAUSE TestAccAWSGlueJob_disappears
=== CONT  TestAccAWSGlueJob_basic
=== CONT  TestAccAWSGlueJob_Tags
=== CONT  TestAccAWSGlueJob_Description
=== CONT  TestAccAWSGlueJob_GlueVersion
=== CONT  TestAccAWSGlueJob_NotificationProperty
=== CONT  TestAccAWSGlueJob_MaxRetries
=== CONT  TestAccAWSGlueJob_ExecutionProperty
=== CONT  TestAccAWSGlueJob_PythonShell
=== CONT  TestAccAWSGlueJob_disappears
=== CONT  TestAccAWSGlueJob_nonOverridableArguments
=== CONT  TestAccAWSGlueJob_MaxCapacity
=== CONT  TestAccAWSGlueJob_WorkerType
=== CONT  TestAccAWSGlueJob_SecurityConfiguration
=== CONT  TestAccAWSGlueJob_Command
=== CONT  TestAccAWSGlueJob_DefaultArguments
=== CONT  TestAccAWSGlueJob_Timeout
2020/09/22 11:08:34 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
=== CONT  TestAccAWSGlueJob_disappears
    resource_aws_glue_job_test.go:644: [INFO] Got non-empty plan, as expected
2020/09/22 11:08:54 [DEBUG] Getting IAM Policy Version: {
  PolicyArn: "arn:aws:iam::aws:policy/service-role/AWSGlueServiceRole",
  VersionId: "v4"
}
2020/09/22 11:08:54 [DEBUG] Waiting for state to become: [success]
--- PASS: TestAccAWSGlueJob_disappears (26.19s)
--- PASS: TestAccAWSGlueJob_basic (29.41s)
2020/09/22 11:09:01 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2020/09/22 11:09:08 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSGlueJob_Timeout (43.77s)
--- PASS: TestAccAWSGlueJob_Description (43.81s)
--- PASS: TestAccAWSGlueJob_Command (44.22s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (45.41s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (45.72s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (45.77s)
--- PASS: TestAccAWSGlueJob_GlueVersion (45.84s)
--- PASS: TestAccAWSGlueJob_NotificationProperty (45.94s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (46.39s)
--- PASS: TestAccAWSGlueJob_nonOverridableArguments (46.54s)
--- PASS: TestAccAWSGlueJob_MaxRetries (50.70s)
--- PASS: TestAccAWSGlueJob_Tags (60.33s)
--- PASS: TestAccAWSGlueJob_PythonShell (61.79s)
--- PASS: TestAccAWSGlueJob_WorkerType (62.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.135s

However one test fails consistently in GovCloud (us-gov-west-1)

=== CONT  TestAccAWSGlueJob_nonOverridableArguments
    resource_aws_glue_job_test.go:174: Check 2/4 error: aws_glue_job.test: Attribute 'non_overridable_arguments.%' expected "2", got "0"
--- FAIL: TestAccAWSGlueJob_nonOverridableArguments (11.74s)

@DrFaust92 What we will do is merge this now, and create an issue to followup on this GovCloud issue. @YakDriver suspects this may be an undocumented API discrepancy. Will update this with that issue once I've created it.

[ghost]

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!