service/opsworks: Test Failures Due to custom_json Whitespace Changes

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Recent updates to the testing configurations have triggering a bunch of new OpsWorks acceptance test failures, such as:

=== CONT  TestAccAWSOpsworksApplication_basic
TestAccAWSOpsworksApplication_basic: resource_aws_opsworks_application_test.go:22: After applying this test step, the plan was not empty.
stdout:
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_opsworks_stack.tf-acc will be updated in-place
~ resource "aws_opsworks_stack" "tf-acc" {
agent_version                 = "3454-20200428034055"
arn                           = "arn:aws:opsworks:us-west-2:*******:stack/9b20cbd4-b0cb-4750-81e6-fe858004b533/"
berkshelf_version             = "3.2.0"
configuration_manager_name    = "Chef"
configuration_manager_version = "11.10"
~ custom_json                   = jsonencode( # whitespace changes
{
key = "value"
}
)
default_availability_zone     = "us-west-2a"
default_instance_profile_arn  = "arn:aws:iam::*******:instance-profile/tf-acc-test-2729284709035523090_opsworks_instance"
default_os                    = "Amazon Linux 2016.09"
default_root_device_type      = "ebs"
default_subnet_id             = "subnet-01de2a913a08dc2b9"
hostname_theme                = "Layer_Dependent"
id                            = "9b20cbd4-b0cb-4750-81e6-fe858004b533"
manage_berkshelf              = false
name                          = "tf-acc-test-2729284709035523090"
region                        = "us-west-2"
service_role_arn              = "arn:aws:iam::*******:role/tf-acc-test-2729284709035523090_opsworks_service"
stack_endpoint                = "us-west-2"
use_custom_cookbooks          = false
use_opsworks_security_groups  = false
vpc_id                        = "vpc-009ede0e05bf1b937"
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccAWSOpsworksApplication_basic (25.66s)

The custom_json whitespace change should not be present. This can be fixed by adjusting the shared test configuration to not include the custom_json argument except in testing that requires it. Otherwise, its value should be updated to not include the unexpected whitespace.

Affected Resource(s)

• aws_opsworks_stack

Affected Tests

• TestAccAWSOpsworksApplication_basic
• TestAccAWSOpsworksCustomLayer_basic
• TestAccAWSOpsworksCustomLayer_noVPC
• TestAccAWSOpsworksCustomLayer_tags
• TestAccAWSOpsworksGangliaLayer_basic
• TestAccAWSOpsworksGangliaLayer_tags
• TestAccAWSOpsworksHAProxyLayer_basic
• TestAccAWSOpsworksHAProxyLayer_tags
• TestAccAWSOpsworksInstance_basic
• TestAccAWSOpsworksInstance_UpdateHostNameForceNew
• TestAccAWSOpsworksJavaAppLayer_basic
• TestAccAWSOpsworksJavaAppLayer_tags
• TestAccAWSOpsworksMemcachedLayer_basic
• TestAccAWSOpsworksMemcachedLayer_tags
• TestAccAWSOpsworksMysqlLayer_basic
• TestAccAWSOpsworksMysqlLayer_tags
• TestAccAWSOpsworksNodejsAppLayer_basic
• TestAccAWSOpsworksNodejsAppLayer_tags
• TestAccAWSOpsworksPermission_basic
• TestAccAWSOpsworksPermission_Self
• TestAccAWSOpsworksPhpAppLayer_basic
• TestAccAWSOpsworksPhpAppLayer_tags
• TestAccAWSOpsworksRailsAppLayer_basic
• TestAccAWSOpsworksRailsAppLayer_tags
• TestAccAWSOpsworksStack_CustomCookbooks_SetPrivateProperties
• TestAccAWSOpsworksStack_noVpcBasic
• TestAccAWSOpsworksStack_noVpcCreateTags
• TestAccAWSOpsworksStack_noVpcChangeServiceRoleForceNew
• TestAccAWSOpsworksStack_vpc
• TestAccAWSOpsworksStaticWebLayer_basic
• TestAccAWSOpsworksStaticWebLayer_tags
• TestAccAWSOpsworksRdsDbInstance_basic

References

• Contributing Guide on Running/Writing Acceptance Testing

[bflad]

Fixed in #14886

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!