Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginate aws_route53_route_association #14885

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Paginate aws_route53_route_association #14885

merged 1 commit into from
Aug 31, 2020

Conversation

curator
Copy link
Contributor

@curator curator commented Aug 28, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14872

Release note for CHANGELOG:

Adds support for VPCs with large numbers (>100) of hosted zones attached by properly handling pagination.

Output from acceptance testing:

I (my company) unfortunately do not have an account setup that allows for testing cross-zone/cross-account tests.

@curator curator requested a review from a team August 28, 2020 01:52
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/route53 Issues and PRs that pertain to the route53 service. labels Aug 28, 2020
@curator curator closed this Aug 28, 2020
@curator curator reopened this Aug 28, 2020
@curator
Copy link
Contributor Author

curator commented Aug 28, 2020

I have been able to test efficacy on my company's scenario and have now been able to successfully import a test (but real and live) domain that was on the second page.

@curator curator changed the title Paginate aws_reoute53_route_association Paginate aws_route53_route_association Aug 28, 2020
@bflad bflad added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 28, 2020
@bflad bflad self-assigned this Aug 28, 2020
@bflad bflad linked an issue Aug 28, 2020 that may be closed by this pull request
aws_route53_zone_association seems unable to import association when it is one of many #14884
Closed
bflad
bflad approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for fixing this, @curator 🚀

Output from acceptance testing:

--- PASS: TestAccAWSRoute53ZoneAssociation_CrossAccount (141.27s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_Zone (171.56s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears (172.41s)
--- PASS: TestAccAWSRoute53ZoneAssociation_disappears_VPC (172.76s)
--- PASS: TestAccAWSRoute53ZoneAssociation_basic (174.46s)
--- PASS: TestAccAWSRoute53ZoneAssociation_CrossRegion (179.38s)

@bflad bflad added this to the v3.5.0 milestone Aug 31, 2020
@bflad bflad merged commit bd61728 into hashicorp:master Aug 31, 2020
bflad added a commit that referenced this pull request Aug 31, 2020
@bflad
Update CHANGELOG for #14885
1479b01
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. service/route53 Issues and PRs that pertain to the route53 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.5.0
2 participants
@curator @bflad